Skip to content

Deleted the files issue #2992 #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkars3 wants to merge 3 commits into from
Closed

Deleted the files issue #2992 #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef465b0
Delete ActionMenu.tsx
utkars3 Mar 21, 2023
0e28574
Delete Dialog.docs.json
utkars3 Mar 21, 2023
8ece200
Delete Dialog.tsx
utkars3 Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 0 additions & 138 deletions src/ActionMenu.tsx
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions src/Dialog.docs.json
View file
Open in desktop

This file was deleted.

142 changes: 0 additions & 142 deletions src/Dialog.tsx
View file
Open in desktop
Copy link
Member

@joshblack joshblack Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broccolinisoup should these still be included in src or are they safe to be removed? 👀

Copy link
Author

@utkars3 utkars3 Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack the issue was to delete the files.Have i done something wrong?

Copy link
Member

@joshblack joshblack Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @utkars3! 👋 I think you're totally fine, just wanted to confirm the changes with @broccolinisoup since we ran into some issues specifically with Dialog in our last recent 👀

Just wanted to say thanks for making this PR, by the way! We appreciate it a ton 🙏

Copy link
Member

@broccolinisoup broccolinisoup Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pinging me @joshblack! Yes, as you mentioned we ran into some import/export issues last week and I reverted the Dialog and Dialog2 changes. That means, we will still need to keep src/Dialog.tsx and src/Dialog.docs.json for now.

Copy link
Author

@utkars3 utkars3 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broccolinisoup whats about ActionMenu.tsx

Copy link
Member

@broccolinisoup broccolinisoup Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActionMenu.tsx is good to go! #3059 (comment)

This file was deleted.