Skip to content

Revert Dialog and Dialog(draft) folder refactor that causes import issues #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
broccolinisoup merged 3 commits into from
Mar 15, 2023
Merged

Revert Dialog and Dialog(draft) folder refactor that causes import issues #3040

broccolinisoup merged 3 commits into from
Mar 15, 2023

Conversation

@broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 15, 2023

Dialog and Dialog(draft) causes import issues - so reverting back for now to unblock folks using canary builds - slack ref: https://github.slack.com/archives/C01L618AEP9/p1678918940134579?thread_ts=1678833964.361389&cid=C01L618AEP9

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 15, 2023
@broccolinisoup broccolinisoup requested review from a team and siddharthkp March 15, 2023 23:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c291e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

colebemis
colebemis approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick fix ⚡

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.52 KB (+0.01% 🔺)
dist/browser.umd.js 95.11 KB (+0.01% 🔺)

@broccolinisoup broccolinisoup temporarily deployed to github-pages March 15, 2023 23:29 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3040 March 15, 2023 23:29 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 15, 2023
Merged via the queue into main with commit 51cdbb0 Mar 15, 2023
@broccolinisoup broccolinisoup deleted the revert-dialog-refactor branch March 15, 2023 23:56
@broccolinisoup broccolinisoup mentioned this pull request Mar 21, 2023
Closed
@broccolinisoup broccolinisoup mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@broccolinisoup @colebemis