SegmentedControl: Remove tooltip temporarily and add an accessible name to the button #3010
Conversation
🦋 Changeset detectedLatest commit: ffe3fea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
|
@broccolinisoup just a heads up, the link in the PR description seemed to still include tooltips. I used the latest link from the storybook deploy URL (here) and it worked perfectly! Just wanted to share in case something was going on. |
Ah thanks @joshblack ! I added both in the description now for comparison. |
This PR resolves the axe-violation on the
SegmentedControlIconButtonStorybook Link
Before : https://primer.style/react/storybook/?path=/story/components-segmentedcontrol-features--icon-only&viewMode=story
After: https://primer-da95297a09-13348165.drafts.github.io/storybook/iframe.html?args=&id=components-segmentedcontrol-features--icon-only&viewMode=story
Closes https://github.com/github/primer/issues/1864 (Hubbers only link)
We decided to disable (remove) the tooltip for now and add a discernable name to the button itself until we resolve more critical issues on the tooltip (ref: https://github.com/github/primer/issues/1909).
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.