Button: Do not add [data-size="medium"]` when size is explicitly specified as medium #2929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0144037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
approved these changes
Feb 23, 2023
Contributor
langermank
left a comment
langermank
left a comment
There was a problem hiding this comment.
Thank you for this! 🚀
joshblack
approved these changes
Feb 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Closes #2927
Context
The issue is when
size="medium"prop is passed toButton, the styles provided viasxprop don't apply. With the way we applyButtonstyles that were provided viasxis described here.Issue and solution
The reason that wasn't working for the
size="medium"is because the function is adding[data-size="medium"]but we don't have any styles defined with that data-attribute (Because the default size ofButtonismediumtherefore it is styled on the base class) so it was simply disregarding everything. Simply checking if the size is not equal tomediumsolves the issue.Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.