Skip to content

Fix Truncate regressions #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colebemis merged 2 commits into from
Jan 24, 2023
Merged

Fix Truncate regressions #2810

colebemis merged 2 commits into from
Jan 24, 2023

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Jan 24, 2023

Fixes a regression in #2759 that broke the Truncate types

@colebemis colebemis requested review from a team and JoshBowdenConcepts January 24, 2023 20:51
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39ca94a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colebemis colebemis added the skip changeset This change does not need a changelog label Jan 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 89.02 KB (0%)
dist/browser.umd.js 89.64 KB (+0.01% 🔺)

@colebemis colebemis temporarily deployed to github-pages January 24, 2023 21:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2810 January 24, 2023 21:00 Inactive
@colebemis colebemis temporarily deployed to github-pages January 24, 2023 21:08 — with GitHub Actions Inactive
@colebemis colebemis merged commit 8bdae46 into main Jan 24, 2023
@colebemis colebemis deleted the fix-truncate branch January 24, 2023 21:08
radglob pushed a commit that referenced this pull request Jan 25, 2023
@colebemis @radglob
Fix Truncate regressions (#2810)
44f5478 
* Fix truncate types

* Add displayName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@JoshBowdenConcepts JoshBowdenConcepts Awaiting requested review from JoshBowdenConcepts

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colebemis @joshblack