Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Dec 9, 2022

Enables us to npm install without any need for --legacy-peer-deps. There are conflicting dependencies that come up, most of which have to deal with storybook and seemingly they won't be updated until Storybook 7 is released

Changelog

New

Changed

  • Update @storybook/* deps to make sure they contain React 18 as a peer dep

Removed

  • @whitespace/storybook-addon-html sadly does not have React 18 listed as a peer dep 😞

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

🦋 Changeset detected

Latest commit: 68ce453

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 82.79 KB (0%)
dist/browser.umd.js 83.47 KB (0%)

@joshblack joshblack added the skip changeset This change does not need a changelog label Dec 9, 2022
@joshblack joshblack temporarily deployed to github-pages December 9, 2022 20:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2674 December 9, 2022 20:32 Inactive
@joshblack joshblack marked this pull request as ready for review December 12, 2022 22:15
@joshblack joshblack requested review from a team and mperrotti December 12, 2022 22:15
@joshblack joshblack merged commit e335265 into chore/update-tests-for-react-18 Dec 15, 2022
@joshblack joshblack deleted the feat/update-deps-for-react-18 branch December 15, 2022 17:55
@joshblack joshblack temporarily deployed to github-pages December 15, 2022 18:00 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants