Skip to content

Conversation

@cbix
Copy link

@cbix cbix commented Dec 7, 2022

When trying to theme the ToggleSwitch component, I noticed the color overrides were not applied to the line icon.

Screenshots

Before:
Screenshot from 2022-12-07 15-02-58
After:
Screenshot from 2022-12-07 15-03-21

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@cbix cbix requested review from a team and siddharthkp December 7, 2022 14:07
@cbix cbix force-pushed the fix/toggle-button-color branch from 6229d99 to 1ffe8f6 Compare December 8, 2022 15:52
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

⚠️ No Changeset found

Latest commit: 28aced1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation makes sense to me. Tagging @mperrotti here to double check

@joshblack joshblack added the 💓collab a vibrant hub of collaboration label Dec 9, 2022
@joshblack joshblack requested a review from mperrotti December 9, 2022 20:22
@cbix cbix force-pushed the fix/toggle-button-color branch from 1ffe8f6 to 488195e Compare December 19, 2022 10:35
mperrotti
mperrotti previously approved these changes Jan 4, 2023
@mperrotti
Copy link
Contributor

This is approved for external use, but the colors should not be overridden when used in GitHub products.

@cbix cbix force-pushed the fix/toggle-button-color branch from 488195e to 8d6778c Compare January 13, 2023 13:17
@broccolinisoup
Copy link
Member

@cbix 👋🏻 Do you need help with going further with this PR?

colebemis
colebemis previously approved these changes Feb 1, 2023
@cbix
Copy link
Author

cbix commented Feb 1, 2023

@broccolinisoup it's just waiting to be merged by one of you. Is there anything you need from my side?

Oh, I see now that some snapshots need to be updated. (nvm, seems like those test cases were removed)

@cbix cbix force-pushed the fix/toggle-button-color branch from 8d6778c to 282857b Compare February 1, 2023 07:55
@broccolinisoup broccolinisoup changed the base branch from main to changeset-release/main February 2, 2023 00:50
@broccolinisoup broccolinisoup dismissed stale reviews from colebemis and mperrotti February 2, 2023 00:50

The base branch was changed.

@broccolinisoup broccolinisoup changed the base branch from changeset-release/main to main February 2, 2023 00:50
@cbix
Copy link
Author

cbix commented Mar 7, 2023

Closing now because

@cbix cbix closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💓collab a vibrant hub of collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants