-
Notifications
You must be signed in to change notification settings - Fork 648
ToggleSwitch: use correct color token for line icon #2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6229d99 to
1ffe8f6
Compare
|
broccolinisoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation makes sense to me. Tagging @mperrotti here to double check
1ffe8f6 to
488195e
Compare
|
This is approved for external use, but the colors should not be overridden when used in GitHub products. |
488195e to
8d6778c
Compare
|
@cbix 👋🏻 Do you need help with going further with this PR? |
|
@broccolinisoup it's just waiting to be merged by one of you. Is there anything you need from my side?
|
8d6778c to
282857b
Compare
The base branch was changed.
|
Closing now because
|
When trying to theme the ToggleSwitch component, I noticed the color overrides were not applied to the line icon.
Screenshots
Before:


After:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.