Skip to content

Conversation

@lukasoppermann
Copy link
Collaborator

Summary

This PR updates the accent.fg token in dark mode for both the old (current) and new (v3) tokens.

@lukasoppermann lukasoppermann requested a review from a team as a code owner March 14, 2023 16:25
@lukasoppermann lukasoppermann self-assigned this Mar 14, 2023
@lukasoppermann lukasoppermann requested a review from a team March 14, 2023 16:25
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

⚠️ No Changeset found

Latest commit: a686316

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Variables changed
--- base/dist/scss/colors/_dark.scss	2023-03-29 07:15:37.253378811 +0000
+++ dist/scss/colors/_dark.scss	2023-03-29 07:14:33.568062029 +0000
@@ -77,3 +77,3 @@
     --color-checks-text-secondary: #8b949e;
-    --color-checks-text-link: #58a6ff;
+    --color-checks-text-link: #2f81f7;
     --color-checks-btn-icon: #8b949e;
@@ -108,3 +108,3 @@
     --color-checks-line-selected-bg: rgba(56,139,253,0.15);
-    --color-checks-line-selected-num-text: #58a6ff;
+    --color-checks-line-selected-num-text: #2f81f7;
     --color-checks-line-dt-fm-text: #ffffff;
@@ -126,3 +126,3 @@
     --color-checks-logline-warning-bg: rgba(187,128,9,0.15);
-    --color-checks-logline-command-text: #58a6ff;
+    --color-checks-logline-command-text: #2f81f7;
     --color-checks-logline-section-text: #3fb950;
@@ -306,3 +306,3 @@
     --color-neutral-subtle: rgba(110,118,129,0.1);
-    --color-accent-fg: #58a6ff;
+    --color-accent-fg: #2f81f7;
     --color-accent-emphasis: #1f6feb;
--- base/dist/scss/colors/_dark_colorblind.scss	2023-03-29 07:15:37.273379224 +0000
+++ dist/scss/colors/_dark_colorblind.scss	2023-03-29 07:14:33.584062361 +0000
@@ -77,3 +77,3 @@
     --color-checks-text-secondary: #8b949e;
-    --color-checks-text-link: #58a6ff;
+    --color-checks-text-link: #2f81f7;
     --color-checks-btn-icon: #8b949e;
@@ -108,3 +108,3 @@
     --color-checks-line-selected-bg: rgba(56,139,253,0.15);
-    --color-checks-line-selected-num-text: #58a6ff;
+    --color-checks-line-selected-num-text: #2f81f7;
     --color-checks-line-dt-fm-text: #ffffff;
@@ -126,3 +126,3 @@
     --color-checks-logline-warning-bg: rgba(187,128,9,0.15);
-    --color-checks-logline-command-text: #58a6ff;
+    --color-checks-logline-command-text: #2f81f7;
     --color-checks-logline-section-text: #58a6ff;
@@ -306,3 +306,3 @@
     --color-neutral-subtle: rgba(110,118,129,0.1);
-    --color-accent-fg: #58a6ff;
+    --color-accent-fg: #2f81f7;
     --color-accent-emphasis: #1f6feb;
--- base/dist/scss/colors/_dark_dimmed.scss	2023-03-29 07:15:37.261378976 +0000
+++ dist/scss/colors/_dark_dimmed.scss	2023-03-29 07:14:33.576062195 +0000
@@ -77,3 +77,3 @@
     --color-checks-text-secondary: #768390;
-    --color-checks-text-link: #539bf5;
+    --color-checks-text-link: #2f81f7;
     --color-checks-btn-icon: #768390;
@@ -108,3 +108,3 @@
     --color-checks-line-selected-bg: rgba(65,132,228,0.15);
-    --color-checks-line-selected-num-text: #539bf5;
+    --color-checks-line-selected-num-text: #2f81f7;
     --color-checks-line-dt-fm-text: #cdd9e5;
@@ -126,3 +126,3 @@
     --color-checks-logline-warning-bg: rgba(174,124,20,0.15);
-    --color-checks-logline-command-text: #539bf5;
+    --color-checks-logline-command-text: #2f81f7;
     --color-checks-logline-section-text: #57ab5a;
@@ -306,3 +306,3 @@
     --color-neutral-subtle: rgba(99,110,123,0.1);
-    --color-accent-fg: #539bf5;
+    --color-accent-fg: #2f81f7;
     --color-accent-emphasis: #316dca;
--- base/dist/scss/colors/_dark_high_contrast.scss	2023-03-29 07:15:37.269379142 +0000
+++ dist/scss/colors/_dark_high_contrast.scss	2023-03-29 07:14:33.580062278 +0000
@@ -77,3 +77,3 @@
     --color-checks-text-secondary: #f0f3f6;
-    --color-checks-text-link: #71b7ff;
+    --color-checks-text-link: #2f81f7;
     --color-checks-btn-icon: #f0f3f6;
@@ -108,3 +108,3 @@
     --color-checks-line-selected-bg: rgba(64,158,255,0.15);
-    --color-checks-line-selected-num-text: #71b7ff;
+    --color-checks-line-selected-num-text: #2f81f7;
     --color-checks-line-dt-fm-text: #0a0c10;
@@ -126,3 +126,3 @@
     --color-checks-logline-warning-bg: rgba(224,155,19,0.15);
-    --color-checks-logline-command-text: #71b7ff;
+    --color-checks-logline-command-text: #2f81f7;
     --color-checks-logline-section-text: #26cd4d;
@@ -306,3 +306,3 @@
     --color-neutral-subtle: rgba(158,167,179,0.1);
-    --color-accent-fg: #71b7ff;
+    --color-accent-fg: #2f81f7;
     --color-accent-emphasis: #409eff;
--- base/dist/scss/colors/_dark_tritanopia.scss	2023-03-29 07:15:37.277379307 +0000
+++ dist/scss/colors/_dark_tritanopia.scss	2023-03-29 07:14:33.588062444 +0000
@@ -77,3 +77,3 @@
     --color-checks-text-secondary: #8b949e;
-    --color-checks-text-link: #58a6ff;
+    --color-checks-text-link: #2f81f7;
     --color-checks-btn-icon: #8b949e;
@@ -108,3 +108,3 @@
     --color-checks-line-selected-bg: rgba(56,139,253,0.15);
-    --color-checks-line-selected-num-text: #58a6ff;
+    --color-checks-line-selected-num-text: #2f81f7;
     --color-checks-line-dt-fm-text: #ffffff;
@@ -126,3 +126,3 @@
     --color-checks-logline-warning-bg: rgba(187,128,9,0.15);
-    --color-checks-logline-command-text: #58a6ff;
+    --color-checks-logline-command-text: #2f81f7;
     --color-checks-logline-section-text: #58a6ff;
@@ -306,3 +306,3 @@
     --color-neutral-subtle: rgba(110,118,129,0.1);
-    --color-accent-fg: #58a6ff;
+    --color-accent-fg: #2f81f7;
     --color-accent-emphasis: #1f6feb;

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

🟢 No design token changes found

@lukasoppermann lukasoppermann temporarily deployed to github-pages March 14, 2023 16:31 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 14, 2023 16:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 29, 2023 07:20 Inactive
@lukasoppermann lukasoppermann merged commit d9876a4 into main Mar 29, 2023
@lukasoppermann lukasoppermann deleted the a11y/darkmode-link branch March 29, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants