Skip to content

quickfix for better error messages for color tokens #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasoppermann merged 2 commits into from
Jan 27, 2023
Merged

quickfix for better error messages for color tokens #468

lukasoppermann merged 2 commits into from
Jan 27, 2023

Conversation

@lukasoppermann
Copy link
Collaborator

@lukasoppermann lukasoppermann commented Jan 27, 2023

Summary

Adds better error messages for color references that result in undefined

@lukasoppermann lukasoppermann requested a review from a team as a code owner January 27, 2023 09:03
@lukasoppermann lukasoppermann requested review from a team and langermank January 27, 2023 09:03
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ccba5f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023 •
edited
Loading

Variables changed 
No variables changed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023 •
edited
Loading

🟢 No design token changes found

@github-actions github-actions bot temporarily deployed to storybook-preview January 27, 2023 09:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview January 27, 2023 09:14 Inactive
@lukasoppermann lukasoppermann merged commit 2499883 into main Jan 27, 2023
@lukasoppermann lukasoppermann deleted the better-color-error branch January 27, 2023 09:25
langermank pushed a commit that referenced this pull request Feb 3, 2023
@lukasoppermann @langermank
quickfix for better error messages for color tokens (#468)
ee5cfb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukasoppermann