Skip to content

removing yarn in favour of npm #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasoppermann merged 4 commits into from
Jan 30, 2023
Merged

removing yarn in favour of npm #464

lukasoppermann merged 4 commits into from
Jan 30, 2023

Conversation

@lukasoppermann
Copy link
Collaborator

@lukasoppermann lukasoppermann commented Jan 26, 2023

Summary

This fixes #425 by removing yarn in favor of npm

Todo

  • investigate caching for npm ci
  • could we remove the release script in favor of using npx changeset as we do in some of the actions in any case? (@rezrah)

List of notable changes:

  • removed yarn.lock
  • added package-lock.json
  • updated actions to use npm run and npm ci

What should reviewers focus on?

  • are all actions still working?
  • does installing work fine?

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change
  • Verify the design tokens changed in this PR are expected using the diffing results in this PR

@lukasoppermann lukasoppermann requested a review from rezrah January 26, 2023 10:48
@lukasoppermann lukasoppermann requested a review from a team as a code owner January 26, 2023 10:48
@lukasoppermann lukasoppermann requested review from a team and joshblack January 26, 2023 10:48
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 58c1336

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023 •
edited
Loading

Variables changed 
No variables changed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023 •
edited
Loading

🟢 No design token changes found

@lukasoppermann lukasoppermann temporarily deployed to github-pages January 26, 2023 11:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview January 26, 2023 11:01 Inactive
@lukasoppermann lukasoppermann force-pushed the rm-yarn branch 4 times, most recently from 951a933 to 37e38b5 Compare January 26, 2023 12:45
@lukasoppermann
Copy link
Collaborator Author

lukasoppermann commented Jan 26, 2023

Hey @rezrah it seems one big issue is that @github/prettier-config is not available. I tried using --include=dev as yarn may install dev dependencies by default, but no luck. Any idea?

@lukasoppermann lukasoppermann force-pushed the rm-yarn branch 3 times, most recently from 40c1ddf to e8fe520 Compare January 26, 2023 14:07
colebemis
colebemis approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@lukasoppermann lukasoppermann force-pushed the rm-yarn branch 4 times, most recently from 11f5d96 to 07aa79e Compare January 27, 2023 11:57
@lukasoppermann lukasoppermann temporarily deployed to github-pages January 30, 2023 10:11 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview January 30, 2023 10:12 Inactive
@lukasoppermann lukasoppermann added enhancement dependencies Pull requests that update a dependency file labels Jan 30, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview January 30, 2023 12:16 Inactive
@lukasoppermann lukasoppermann merged commit 57c70a6 into main Jan 30, 2023
@lukasoppermann lukasoppermann deleted the rm-yarn branch January 30, 2023 12:27
langermank pushed a commit that referenced this pull request Feb 3, 2023
@lukasoppermann @rezrah @langermank
removing yarn in favour of npm (#464)
00b1723 
* removing yarn in favour of npm

* remove yarn lock for storybook

* rebuild lock files & remove unused failing import

* trying webpack fix

---------

Co-authored-by: Reza Rahman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@joshblack joshblack joshblack approved these changes

@rezrah rezrah Awaiting requested review from rezrah

+1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to npm

6 participants

@lukasoppermann @jonrohan @joshblack @colebemis @rezrah