Fix Feed icon alignment issue and name collision #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a863479 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
force-pushed
the
gavinmn/fix-feed-icons
branch
from
1fe46df
to
f2eccd6
Compare
…-16.svg, feed-public-16.svg, feed-pull-request-closed-16.svg, feed-pull-request-draft-16.svg, feed-pull-request-open-16.svg
gavinmn
force-pushed
the
gavinmn/fix-feed-icons
branch
from
f2eccd6
to
aa6bdc3
Compare
github-actions
bot
force-pushed
the
gavinmn/fix-feed-icons
branch
from
4e377db
to
c5b9236
Compare
github-actions
bot
force-pushed
the
gavinmn/fix-feed-icons
branch
2 times, most recently
from
c915677
to
a1b7b30
Compare
gavinmn
force-pushed
the
gavinmn/fix-feed-icons
branch
from
a1b7b30
to
279cfac
Compare
gavinmn
force-pushed
the
gavinmn/fix-feed-icons
branch
from
279cfac
to
e9cee38
Compare
gavinmn
changed the title
Merged
github-actions
bot
force-pushed
the
gavinmn/fix-feed-icons
branch
from
aa6ad0c
to
62e7051
Compare
github-actions
bot
force-pushed
the
gavinmn/fix-feed-icons
branch
from
62e7051
to
e214cd5
Compare
CameronFoxly
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Looks like this one is another 17 x 16px version 🤦
I wonder why that keeps happening...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the naming issue on
feed-issue-reopenandfeed-issue-opencaused by them both being namedfeed-issue-openbefore.Context #977 (comment)
Also including an alignment fix for the other Feed icons. I think the Octicons plugin upload
17px × 16pxicons again. This should move all to be16px × 16px.