Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 12px × icon #937

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Add 12px × icon #937

merged 6 commits into from
Apr 27, 2023

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Apr 3, 2023

@gavinmn gavinmn requested a review from a team as a code owner April 3, 2023 20:21
@gavinmn gavinmn requested a review from tallys April 3, 2023 20:21
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: fd77c48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ ✅

Copy link
Contributor

@tallys tallys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes to ✖️

@gavinmn gavinmn enabled auto-merge (squash) April 3, 2023 20:49
@gavinmn
Copy link
Contributor Author

gavinmn commented Apr 3, 2023

Hmm... @colebemis any idea on the failing test here? We already have XIcon in the snapshot so I was expecting this to pass.

@gavinmn gavinmn merged commit 6c94e0e into main Apr 27, 2023
@gavinmn gavinmn deleted the gavinmn/x12 branch April 27, 2023 19:34
@primer-css primer-css mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants