Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save passkey-fill-24.svg, passkey-fill-16.svg #927

Merged
merged 10 commits into from
Mar 7, 2023
Merged

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Mar 2, 2023

@gavinmn gavinmn requested a review from tallys March 2, 2023 19:41
@gavinmn gavinmn requested a review from a team as a code owner March 2, 2023 19:41
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

🦋 Changeset detected

Latest commit: e2b94c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gavinmn gavinmn temporarily deployed to github-pages March 2, 2023 19:46 — with GitHub Actions Inactive
@colebemis
Copy link
Contributor

Should this be called passkey-fill?

@gavinmn
Copy link
Contributor Author

gavinmn commented Mar 2, 2023

Should this be called passkey-fill?

🤔 That's a good question. It's technically a filled icon, but it's not a filled icon with an outline icon counterpart since it's made specifically to follow the passkey spec. @tallys any opinions since this is kind of half a branded icon?

@gavinmn gavinmn temporarily deployed to github-pages March 2, 2023 20:00 — with GitHub Actions Inactive
@hagould
Copy link

hagould commented Mar 3, 2023

We need "darkmode" versions of these as well for visibility.

Are there any code examples you can point me to on how folks use svgs in-place of icons / resolve github color theme differences?

Ex:
Screen Shot 2023-03-03 at 2 15 44 PM

@gavinmn
Copy link
Contributor Author

gavinmn commented Mar 3, 2023

We don't do different colors or modifications for Octicons in dark mode as far as I know, but once these are merged and released to the library they should be able to be used the same way you're currently using Octicons. Does that work or do you need to use the SVGs earlier?

@tallys
Copy link
Contributor

tallys commented Mar 6, 2023

@gavinmn and @colebemis let's stick to our naming conventions and give it 'fill' title for consistency, even though there's not a counterpart. This is a bit of an edge case, but I think consistency in the library makes more sense

@gavinmn gavinmn changed the title Save passkey-24.svg, passkey-16.svg Save passkey-fill-24.svg, passkey-fill-16.svg Mar 6, 2023
@hagould
Copy link

hagould commented Mar 6, 2023

they should be able to be used the same way you're currently using Octicons

Ah thanks, I didn't know this. In that case this should be fine, thank you so much!

@gavinmn gavinmn merged commit ffd32dd into main Mar 7, 2023
@gavinmn gavinmn deleted the gavinmn/passkeys branch March 7, 2023 20:27
@primer-css primer-css mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants