feat(octicons-react): add files to package.json and update npmignore #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 09b5a77 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
changed the title
keithamus
approved these changes
Jan 13, 2023
187880
approved these changes
Jan 15, 2023
Merged
gr2m
reviewed
Jan 25, 2023
Comment on lines
+10
to
+13
| "exports": { | ||
| "import": "dist/index.esm.js", | ||
| "require": "dist/index.umd.js" | ||
| }, |
There was a problem hiding this comment.
fyi I now get an error when running next build
> next build
info - Skipping validation of types
info - Linting
info - Creating an optimized production build
info - Compiled successfully
info - Collecting page data .Error [ERR_INVALID_PACKAGE_TARGET]: Invalid "exports" main target "dist/index.umd.js" defined in the package config /node_modules/@primer/octicons-react/package.json; targets must start with "./"
at new NodeError (node:internal/errors:400:5)
at invalidPackageTarget (node:internal/modules/esm/resolve:389:10)
at resolvePackageTargetString (node:internal/modules/esm/resolve:445:11)
at resolvePackageTarget (node:internal/modules/esm/resolve:522:12)
at resolvePackageTarget (node:internal/modules/esm/resolve:571:31)
at packageExportsResolve (node:internal/modules/esm/resolve:635:27)
at resolveExports (node:internal/modules/cjs/loader:538:36)
at Module._findPath (node:internal/modules/cjs/loader:607:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:1025:27)
at mod._resolveFilename (/Users/gr2m/code/github/howie/app/node_modules/next/dist/build/webpack/require-hook.js:27:32) {
code: 'ERR_INVALID_PACKAGE_TARGET'
}
I think these should be
"exports": {
"import": "./dist/index.esm.js",
"require": "./dist/index.umd.js"
},There was a problem hiding this comment.
I confirmed that making the change resolves the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
package.jsonand.npmignorefor the@primer/octicons-reactpackage. Specifically,filesarray topackage.jsonto include only the files needed for publish.npmignorefile to match on patterns currently being included in the packageexportsfield topackage.jsonwith theimportandrequirekeys