Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react.mdx #850

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Update react.mdx #850

merged 1 commit into from
Oct 7, 2022

Conversation

jirihofman
Copy link
Contributor

Replacing dead link for aria-label with a working one.

Replacing dead link for `aria-label` with a working one.
@jirihofman jirihofman requested a review from a team as a code owner October 5, 2022 21:17
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022

⚠️ No Changeset found

Latest commit: f805e01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you ✨

@jirihofman
Copy link
Contributor Author

Any chance to get the Deploy / Preview / Deploy (pull_request) job fixed somehow?

@colebemis
Copy link
Contributor

Thank you, @jirihofman! 💖

Any chance to get the Deploy / Preview / Deploy (pull_request) job fixed somehow?

We can probably copy the same workflow we use in Primer React: https://github.com/primer/react/blob/main/.github/workflows/deploy_preview_forks.yml

@colebemis colebemis merged commit 0c758fe into primer:main Oct 7, 2022
@jirihofman jirihofman deleted the patch-1 branch October 7, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants