Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save file-directory-open-fill-16.svg #762

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Save file-directory-open-fill-16.svg #762

merged 6 commits into from
Mar 22, 2022

Conversation

edokoa
Copy link
Contributor

@edokoa edokoa commented Mar 2, 2022

Adds the file-directory-open-fill icon designed by @vdepizzol to Octicons as requested in https://github.com/github/primer/issues/729

We can discuss the naming of this icon cc: @ashygee, @colebemis, @Juliusschaeper. I chose this one because it's a new modifier applied over the fill variant, not sure if we will have / need a non-filled version of this.

@edokoa edokoa requested a review from a team as a code owner March 2, 2022 14:51
@edokoa edokoa requested a review from ashygee March 2, 2022 14:51
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2022

🦋 Changeset detected

Latest commit: 3d17a14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks great! Ship it!

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good ❤️

.changeset/purple-planets-sleep.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants