refactor(delay): update how LiveRegionElement throttles announcements for better ordering of announcements #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for better ordering of announcements
🦋 Changeset detectedLatest commit: d185fef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Changed
waitMsoption in constructor to adelayattribute on the custom elementupdateContainerWithMessageis throttled. Instead of keeping a separate queue of messages to be announced, we now have a pending state in the live region. This makes it so that we still only announce once everydelaybut the ordering of messages is improved by making sure "immediate" ones are announced sooner than if they were added to the back of the throttle queueRemoved
Testing & Reviewing