Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax highlight for js/ts with export default #372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xeaone
Copy link

@xeaone xeaone commented Sep 29, 2023

The syntax highlighting has unexpected color when using export default inline with class in js/ts.

Notice the curly brackets, semicolon, and parentheses all adopt the class name color. This color change also modifies other syntax. It seems as though that a possible solution might be to remove the scope "meta.export.default" (Dark and Light do not include this scope).

Before

image

After

image

Merge checklist

  • Added/updated colors
  • Added/updated documentation/README
  • Tested in GitHub Light Default theme

Take a look at the Contribute section for more information on how test your changes locally.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

⚠️ No Changeset found

Latest commit: 959fe64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant