Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getColors function to use require directly on JSON files #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeepakKumarKhatri
Copy link

This issue is refred on issue #363 in which I refactored the getColors function in colors.js to use require directly on the json files for each theme's color object. The current implementation of the function declares unnecessary variables for each theme's color object, which increases complexity and can be simplified.

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

⚠️ No Changeset found

Latest commit: ad2ec4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant