Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for strikethrough #296

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Add support for strikethrough #296

merged 2 commits into from
Jul 14, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 14, 2022

This closes #260 by adding support for strikethrough.

Before After
Screen Shot 2022-07-14 at 16 00 45 Screen Shot 2022-07-14 at 16 03 19

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: 4fe2d37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/dark-colorblind.json	2022-07-14 07:06:56.767766709 +0000
@@ -515,2 +515,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/dark-default.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/dark-default.json	2022-07-14 07:06:56.767766709 +0000
@@ -515,2 +515,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/dark-dimmed.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/dark-dimmed.json	2022-07-14 07:06:56.767766709 +0000
@@ -515,2 +515,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/dark-high-contrast.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/dark-high-contrast.json	2022-07-14 07:06:56.767766709 +0000
@@ -519,2 +519,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/dark.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/dark.json	2022-07-14 07:06:56.767766709 +0000
@@ -436,2 +436,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/light-colorblind.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/light-colorblind.json	2022-07-14 07:06:56.767766709 +0000
@@ -500,2 +500,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/light-default.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/light-default.json	2022-07-14 07:06:56.767766709 +0000
@@ -500,2 +500,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/light-high-contrast.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/light-high-contrast.json	2022-07-14 07:06:56.767766709 +0000
@@ -503,2 +503,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",
--- base/themes/light.json	2022-07-14 07:07:00.363977617 +0000
+++ themes/light.json	2022-07-14 07:06:56.767766709 +0000
@@ -432,2 +432,10 @@
     {
+      "scope": [
+        "markup.strikethrough"
+      ],
+      "settings": {
+        "fontStyle": "strikethrough"
+      }
+    },
+    {
       "scope": "markup.inline.raw",

@simurai simurai merged commit b6e03e1 into main Jul 14, 2022
@simurai simurai deleted the strikethrough branch July 14, 2022 07:08
@primer-css primer-css mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to strikethroughs in the editor
1 participant