Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make diff editor colors more opaque #28

Merged
merged 2 commits into from
May 13, 2020
Merged

Make diff editor colors more opaque #28

merged 2 commits into from
May 13, 2020

Conversation

this-fifo
Copy link
Contributor

@this-fifo this-fifo commented May 12, 2020 •
edited by simurai
Loading

This is a small tweak suggestion for #18

Closes #18

@edokoa
Copy link

edokoa commented May 12, 2020

Pinging @simurai

@paramaggarwal
Copy link
Contributor

Please make the change in src/theme.js - if we edit the theme .json files directly then they will go out of sync over time. Thanks!

simurai
simurai approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated it in src/theme.js.

🚢 👍

@simurai simurai merged commit d9b6f20 into primer:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Red and green colors in the Working Tree should have more contrast
4 participants
@this-fifo @edokoa @paramaggarwal @simurai