Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red and green colors in the Working Tree should have more contrast #18

Closed
nil opened this issue May 8, 2020 · 1 comment · Fixed by #28
Closed

Red and green colors in the Working Tree should have more contrast #18

nil opened this issue May 8, 2020 · 1 comment · Fixed by #28

Comments

@nil
Copy link

nil commented May 8, 2020

Github theme

On the split view that previews the difference between the old and modified file, modified lines have a red (for removed) and green (for added). These colors don't have enough contrast and they are quite difficult to spot, specially the reds.

Also, the actual changed text has a different background, but with the current colors it is almost impossible to spot.

You can see the original theme has a much higher contrast, which makes changes easier to see:

Default theme

@this-fifo
Copy link
Contributor

I made a small tweak and thought it look more prominent while still using the same colors from primer

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants