Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
a11y-tooltip-interactive-trigger
may throw an error on<Tooltip>
usages that use values other than astring
for thehref
attribute:a11y-tooltip-interactive-trigger
throws an error (nonInteractiveLink
) for the following:This is because a value is being passed to the
href
through JSX, (i.e.avatar.avatarLink
). This PR aims to pass possiblenonInteractiveLink
errors if they have an href with a JSX-like value.In addition, this PR adds optional chaining to
getJSXOpeningElementAttribute
to avoid an error being thrown when noname
is present.