Add prefer-action-list-item-onselect
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 825cda1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iansan5653
approved these changes
Aug 26, 2024
siddharthkp
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onClicktoActionList.Item#205Adds a new recommended lint rule to prevent accessibility issues where developers used
onClickfor anActionList.Itemcomponent, but should have usedonSelectinstead, so that it is keyboard accessible. Since this is almost always an accessibility violation in practice, I've enabled it by default and marked it as an error.This rule is typically auto-fixable as it involves renaming the property from
onClicktoonSelect, which is sufficient to fix the issue. In some cases, type-checking errors which are not auto-fixable may result since a callback handler may have only expected mouse events. In most cases this can be fixed by adding aMouseEvent | KeyboardEventtype annotation.