bump eslint-plugin-github to v5.0.1

[khiga8]

Bumps the dependency, eslint-plugin-github, to the latest major version which includes:

• release notes v5.0.0: drops support for node 14 and node 16 in favor of node 18.
• release notes v5.0.1 : changes to the recommended config for no-redundant-roles.

[changeset-bot]

🦋 Changeset detected

Latest commit: 726aa88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-primer-react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[joshblack]

@khiga8 for v5, do we need to update any deps on our end (or would consumers need to make sure eslint deps are updated)?

[khiga8]

Hey @joshblack! The main notable change is that we dropped support in eslint-plugin-github for node 14 and node 16 in favor of node 18.

I see that ci.yml is already running node 18 so I don't believe anything needs to change.

[joshblack]

@khiga8 ah thanks for explaining the node change. In this case, if someone is using eslint-plugin-primer-react and is using Node 14 or 16 then it would no longer work as expected? (Due to usage of eslint-plugin-github and it no longer supporting these versions)

For context, I'm not looking at this from the perspective of someone using the package and if this would be a breaking change for them or not.

[khiga8]

Hey @joshblack! Thats a great question.. 👀 .

I dropped node 14 in eslint-plugin-github because I was running into issues with running tests specifically in a node 14 test build. I reached out on slack thread, and it was pointed out that we generally only support Node LTS so it seemed reasonable to drop node 14/16. This seems to align with how node 20 will soon be the the default in GitHub Actions

The SyntaxError we saw in node 14 seemed related to the library test setup, and not the actively shipped code. It is possible the plugin will continue to run as expected for consumers in Node 14/Node 16. However, because we formally dropped node 14 and node 16 from the library testing matrix, we won't be able to guarantee that the plugin will work so I decided to cut a major release version just in case!

If we merge this in, it could be a good idea to cut a major release to be safe, but I did notice that the CI test matrix for eslint-plugin-primer-react only runs node 18 anyways while the CI test for primer/react only runs node 20. Does this mean that technically these libraries are already not formally supporting node <18 🤔 ? Curious to hear your thoughts!

[joshblack]

Thanks for taking the time to explain @khiga8! Would you mind including a changeset? Then should be good to go 💯