Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eslint-plugin-github to dependencies #166

Merged
merged 3 commits into from
May 6, 2024

Conversation

chadfawcett
Copy link
Contributor

@chadfawcett chadfawcett commented May 1, 2024

Resolves #165

If this change makes sense I'd be happy to add a changeset.

@chadfawcett chadfawcett requested a review from a team as a code owner May 1, 2024 19:42
@chadfawcett chadfawcett requested a review from joshblack May 1, 2024 19:42
Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 2c9ca79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies would be great! Would you mind adding a changeset too and we can get this released? 👀

@chadfawcett
Copy link
Contributor Author

@joshblack Should be good to go now!

@joshblack joshblack merged commit 4c3d9b4 into primer:main May 6, 2024
3 checks passed
@primer-css primer-css mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error upgrading past v4.0.3 - eslint-plugin-github should be dependency
2 participants