-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Removing !important
from letter-spacing
marketing typography
#2613
Merged
langermank
merged 2 commits into
main
from
stamat/marketing-letter-spacing-not-important
May 7, 2024
Merged
[a11y] Removing !important
from letter-spacing
marketing typography
#2613
langermank
merged 2 commits into
main
from
stamat/marketing-letter-spacing-not-important
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 04265f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stamat
changed the title
removing !important from letter-spacing marketing typography
[a11y] Removing Apr 24, 2024
!important
from letter-spacing
marketing typography
@langermank hey hey, when do you think this patch can be released? Just curious! 🙏 Thanks legend! |
langermank
approved these changes
May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Hello there! 👋
We've got like "trillion" accessibility issues for not allowing letter spacing change by the assistive plugins on dotcom marketing pages. So I would really like to solve these and remove
!important
on letter spacing. 🙏I've created an override only for the
/marketing/type/typography.scss
file on dotcom https://github.com/github/github/pull/322450 :!important
.The only concern is that the users that might use the
mktg
styles might get impacted, but i think that Impact is minor, if not nonexiting.That's about it. Do help me merge/deploy this 🙏 ❤️
Can these changes ship as is?