Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifecycle status labels from docs #808

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Oct 31, 2024

Summary

Resolves https://github.com/github/primer/issues/4380

🔗 Preview

List of notable changes:

  • removes all lifecycle status labels
  • only shows 'Reviewed for accessibility' label if marked as true
  • pages run through formatter (prettier), any issues fixed automatically

What should reviewers focus on?

  • Have I missed any labels?

Steps to test:

  1. Use the Preview link and go through all component pages

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screenshot 2024-10-31 at 19 15 39 Screenshot 2024-10-31 at 19 16 03
Before After
Screenshot 2024-10-31 at 19 16 24 Screenshot 2024-10-31 at 19 16 16

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 9ceb2fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

🟢 No design token changes found

Copy link
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah marked this pull request as ready for review October 31, 2024 19:25
Copy link

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner! Thank you

@rezrah rezrah merged commit ec0231e into main Nov 1, 2024
18 checks passed
@rezrah rezrah deleted the rezrah/remove-docs-lifecycle-status branch November 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants