-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE YET] Match header to new docs #790
base: main
Are you sure you want to change the base?
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! This looks awesome! Leaving some feedback from the deployment link.
I believe this should be Primer / Brand UI
, since that's the page the user is currently on, and Brand UI should not be listed to the right with the other links.
Is it possible to update the side nav in this PR to match new docs as well? Main things missing is Mona Sans. If the section headers aren't clickable, I think they're fine left in gray/muted color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'm sorry, I mentioned in Slack but I should have put it here -
|
Closes https://github.com/github/primer/issues/4166
We should wait until the new docs site is launched before merging this.
Summary
Updates the design of the docs site navigation to match the new Primer docs site (https://github.com/github/primer-docs) to give a more "seamless" feel when navigating between the different sub-sites.
We chose not to make these changes in doctocat to avoid accidentally breaking things downstream.
List of notable changes:
What should reviewers focus on?
Confirm that this matches the design of the new Primer docs site.
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots:
Child pages
Landing page