-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using SD prefix instead of adding it to the tokens json file #727
Conversation
|
🔍 Design token changes foundView CSS variable changes+ --brand-controlStack-large-gap-spacious: var(--base-size-12); + --brand-controlStack-large-gap-condensed: var(--base-size-8); + --brand-controlStack-large-gap-auto: var(--base-size-8); + --brand-controlStack-medium-gap-spacious: var(--base-size-12); + --brand-controlStack-medium-gap-condensed: var(--base-size-8); + --brand-controlStack-small-gap-spacious: var(--base-size-16); + --brand-controlStack-small-gap-condensed: var(--base-size-8); |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
7c15667
to
117ed99
Compare
117ed99
to
a13883d
Compare
It seems to not be possible with SD to have a prefix for the source tokens but not for the included ones. At least not without a custom format. @rezrah do we need output references or could we output hex values? |
994a19b
to
3046811
Compare
b22c77e
to
011c530
Compare
011c530
to
3942d9b
Compare
9283b21
to
c3157d0
Compare
With a slightly hacky transformer it is now working. We will need to remove this later: https://primer-5bb7c18307-26139705.drafts.github.io/brand/primitives/color |
c3157d0
to
8fbe30b
Compare
8fbe30b
to
6810b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I didn't find any broken or missing tokens. VRT shows no diff either. 🎉
Summary
This pr replaces the use of a custom namespace implantation that requires token files to have the name space in them with the out of the box style dictionary prefix. This allows us to use a lot of upstream files instead of duplicating them just to add a namespace.