Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint-plugin-github to latest #613

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Jun 18, 2024

Summary

As per our Accessibility Automation Scorecard, we need to update eslint-plugin-github to the latest version to ensure that our codebase is up-to-date with the latest accessibility standards.

List of notable changes:

  • Update eslint-plugin-github to the latest version

What should reviewers focus on?

  • Ensure that linting jobs in the CI pass

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Jun 18, 2024

⚠️ No Changeset found

Latest commit: acad172

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 18, 2024

🟢 No design token changes found

@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from 123b699 to 484f7f3 Compare June 18, 2024 10:33
Copy link
Contributor

github-actions bot commented Jun 18, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from 4892272 to 8c4b1dd Compare June 18, 2024 11:22
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from c9339c0 to b0aff7f Compare June 19, 2024 12:46
@joshfarrant joshfarrant marked this pull request as ready for review June 19, 2024 13:45
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshfarrant

@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from b0aff7f to 0fe4840 Compare June 21, 2024 08:05
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch 2 times, most recently from b1c3a68 to dedb3cc Compare June 21, 2024 08:51
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from e7a8984 to 7fecbd1 Compare June 21, 2024 14:25
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from 7fecbd1 to a4d2878 Compare June 21, 2024 14:34
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from edbb5e5 to 284244e Compare July 17, 2024 09:40
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from 284244e to bda854e Compare July 25, 2024 13:20
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from bda854e to 078c45d Compare August 5, 2024 09:28
@joshfarrant joshfarrant force-pushed the joshfarrant/bump-eslint-plugin-github branch from 078c45d to acad172 Compare September 27, 2024 09:47
@joshfarrant joshfarrant merged commit 14c2c2a into main Sep 27, 2024
18 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/bump-eslint-plugin-github branch September 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants