- fix #6164 optimize menu bar #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move getAriaSetSize to computed - optimize getAriaPosInset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
maybe it should be extended to all menu components? example: TieredMenu |
Makes sense, @tugcekucukoglu does this fix make sense to you, and should I apply it in other components? |
tugcekucukoglu
approved these changes
Aug 22, 2024
|
I think it can be applied to other components as well. |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Fixes #6164
getAriaSetSizewas a method iterating over the whole (or subset) of items. Moved this to computed as it doesn't need any argsgetAriaPosInset- slightly optimized so it works with computed list instead of executing the filtering over whole list every time.