Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuBar]: Slow performance #6164

Closed
FabienVINCENT opened this issue Aug 1, 2024 · 5 comments · Fixed by #6176 or twin-tigon/hypermodern-python-talk#4 · May be fixed by nerdy-tech-com-gitub/litlyx#11
Closed

[MenuBar]: Slow performance #6164

FabienVINCENT opened this issue Aug 1, 2024 · 5 comments · Fixed by #6176 or twin-tigon/hypermodern-python-talk#4 · May be fixed by nerdy-tech-com-gitub/litlyx#11
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@FabienVINCENT
Copy link
Contributor

Describe the bug

When we have a large amount of data the component is very slow when displaying the submenus or hovers.

in primevue2 I had the same menu but I didn't have this problem (try in primevue3 same problem).

I tried with the Aura theme or with Tailwind presets, it's the same.

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-tk2bqe?file=src/App.vue

PrimeVue version

4.0.3

Vue version

4.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

Arc, chrome, firefox

Steps to reproduce the behavior

  1. Click on menu item
  2. hover a submenu item
  3. the submenu with large content is very slow and hover is laggy

Expected behavior

No response

@FabienVINCENT FabienVINCENT added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 1, 2024
avramz added a commit to avramz/primevue that referenced this issue Aug 2, 2024
- move getAriaSetSize to computed
- optimize getAriaPosInset
@avramz
Copy link
Contributor

avramz commented Aug 2, 2024

Can reproduce, fix in PR

@FabienVINCENT
Copy link
Contributor Author

I confirm that it improves performance. On tests with 500 items it is still a little laggy but much less so. Thanks

@avramz
Copy link
Contributor

avramz commented Aug 5, 2024

There is also a transition on each list item, which visually looks like it's lagging when working with bigger lists, turning that one off improved overall experience for me. cc @FabienVINCEN
Screenshot 2024-08-05 at 2 03 07 PM
T

@FabienVINCENT
Copy link
Contributor Author

There is also a transition on each list item, which visually looks like it's lagging when working with bigger lists, turning that one off improved overall experience for me. cc @FabienVINCEN Screenshot 2024-08-05 at 2 03 07 PM T

not sure if this helps much in my case

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 22, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.5 milestone Aug 22, 2024
tugcekucukoglu added a commit that referenced this issue Aug 22, 2024
LeaderbotX400 pushed a commit to LeaderbotX400/primevue that referenced this issue Aug 29, 2024
- move getAriaSetSize to computed
- optimize getAriaPosInset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
3 participants