Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber : In Mobile mode value are getting trigger two times #3951

Closed
mrrohit1 opened this issue Jan 13, 2023 · 1 comment · Fixed by #3959
Closed

InputNumber : In Mobile mode value are getting trigger two times #3951

mrrohit1 opened this issue Jan 13, 2023 · 1 comment · Fixed by #3959
Assignees
@melloware
Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@mrrohit1
Copy link

Describe the bug

Steps:
Open screen containing InputNumber in Android/Ios
Try to press + or - button values are getting increase or decrease twice.

In Console you will get
Unable to preventDefault inside passive event listener invocation.

Reproducer

No response

PrimeReact version

8.7.3

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Open screen containing InputNumber in Android/Ios
  2. Try to press + or - button values are getting increase or decrease twice.

Expected behavior

Value should be increase or decrease by step value
@mrrohit1 mrrohit1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 13, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 13, 2023
@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 13, 2023
@melloware melloware self-assigned this Jan 13, 2023
@melloware
Copy link
Member

Already reported and fixed for 8.7.4: #3943

But the real issue is this: #3949 it should be user Pointer events not mouse events

melloware added a commit to melloware/primereact that referenced this issue Jan 15, 2023
@melloware
Fix primefaces#3951/primefaces#3943: InputNumber mobile spin handling
f3d346a
@melloware melloware mentioned this issue Jan 15, 2023
Merged
@melloware melloware reopened this Jan 15, 2023
@github-actions github-actions bot added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible and removed Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted labels Jan 15, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. Device: Mobile Issue or pull request is *only* related to Mobile device and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2023
melloware added a commit that referenced this issue Jan 22, 2023
@melloware
Fix #3951/#3943: InputNumber mobile spin handling (#3959)
567f3e8
mflagey pushed a commit to mflagey/primereact that referenced this issue Feb 14, 2023
@melloware @mflagey
Fix primefaces#3951/primefaces#3943: InputNumber mobile spin handling (…
cc1e716 
…primefaces#3959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3951/#3943: InputNumber mobile spin handling melloware/primereact
2 participants
@melloware @mrrohit1