Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: increased value by 2 on touch device #3943

Closed
SlavaGeorgiev opened this issue Jan 10, 2023 · 4 comments · Fixed by #3944 or #3959
Closed

InputNumber: increased value by 2 on touch device #3943

SlavaGeorgiev opened this issue Jan 10, 2023 · 4 comments · Fixed by #3944 or #3959
Assignees
@melloware
Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Milestone
9.0.0-beta.1

Comments

@SlavaGeorgiev
Copy link

SlavaGeorgiev commented Jan 10, 2023 •
edited
Loading

Describe the bug

The component InputNumber increased or decreases the value by 2 when using it on a touch device. This happens not on desktop devices. Please see the sandbox. This needs to be opened into new window to reproduce the error. In the sandbox it self it doesn't happen. Additionally following error is appearing in the console:

Unable to preventDefault inside passive event listener invocation.

image

Reproducer

https://codesandbox.io/s/late-rgb-jhl1l4?file=/src/App.tsx

PrimeReact version

8.7.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chome 108.0.5359.124

Steps to reproduce the behavior

  1. Open Sandbox link https://codesandbox.io/s/late-rgb-jhl1l4?file=/src/App.tsx
  2. image Open in new Window
  3. Switch to phone or tablet
  4. increase or decrease value by clicking on the buttons.

Expected behavior

Value should be decreased by one or as specified when using on touch device.
@SlavaGeorgiev SlavaGeorgiev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 10, 2023
@melloware melloware changed the title Component: InputNumber increased value by 2 on touch device InputNumber: increased value by 2 on touch device Jan 10, 2023
@melloware melloware added Device: Mobile Issue or pull request is *only* related to Mobile device and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 10, 2023
@melloware melloware self-assigned this Jan 10, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 10, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 10, 2023
@melloware
Fix primefaces#3943: Remove preventDefault from touch events
22a1c4b
melloware added a commit to melloware/primereact that referenced this issue Jan 10, 2023
@melloware
Fix primefaces#3943: Remove preventDefault from touch events
cfc5037
@melloware melloware mentioned this issue Jan 10, 2023
Merged
@melloware
Copy link
Member

Thanks for the report!

melloware added a commit that referenced this issue Jan 10, 2023
@melloware
Fix #3943: Remove preventDefault from touch events (#3944)
0c66f81
@melloware melloware mentioned this issue Jan 13, 2023
Closed
melloware added a commit to melloware/primereact that referenced this issue Jan 15, 2023
@melloware
Fix primefaces#3951/primefaces#3943: InputNumber mobile spin handling
f3d346a
@melloware melloware mentioned this issue Jan 15, 2023
Merged
@melloware
Copy link
Member

I submitted a better fix!

@melloware melloware reopened this Jan 15, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2023
@SlavaGeorgiev
Copy link
Author

By when can we expect to have it available?

@melloware
Copy link
Member

Hopefully very soon. It's up to PrimeTek I have no control over releases 😀

melloware added a commit that referenced this issue Jan 22, 2023
@melloware
Fix #3951/#3943: InputNumber mobile spin handling (#3959)
567f3e8
mflagey pushed a commit to mflagey/primereact that referenced this issue Feb 14, 2023
@melloware @mflagey
Fix primefaces#3951/primefaces#3943: InputNumber mobile spin handling (…
cc1e716 
…primefaces#3959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
9.0.0-beta.1
2 participants
@melloware @SlavaGeorgiev