Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectButton: Add allowEmpty property #13853

Closed
gucal opened this issue Oct 11, 2023 · 1 comment · Fixed by #13854
Closed

SelectButton: Add allowEmpty property #13853

gucal opened this issue Oct 11, 2023 · 1 comment · Fixed by #13854
Assignees
@gucal
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Milestone
16.4.4

Comments

@gucal
Copy link
Contributor

gucal commented Oct 11, 2023

Same feature in PrimeVue: see the issue primefaces/primevue#3973
see the PR: primefaces/primevue#4107
@gucal gucal added the Type: New Feature Issue contains a new feature or new component request label Oct 11, 2023
@gucal gucal added this to the 16.4.2 milestone Oct 11, 2023
@gucal gucal self-assigned this Oct 11, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
gucal added a commit that referenced this issue Oct 11, 2023
@gucal
Fix #13853 - SelectButton: Add allowEmpty property
c9869e3
@gucal gucal mentioned this issue Oct 11, 2023
Merged
gucal added a commit that referenced this issue Oct 11, 2023
@gucal
Merge pull request #13854 from primefaces/issue-13853
a45bc1c 
Fix #13853 - SelectButton: Add allowEmpty property
@rosenthalj rosenthalj mentioned this issue Oct 18, 2023
Closed
@ghost
Copy link

ghost commented Oct 19, 2023

This is breaking change and was not listed in changelog as breaking. I believe it would be better to have default value for allowEmpty set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucal gucal

Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
16.4.4
Development

Successfully merging a pull request may close this issue.

Fix #13853 - SelectButton: Add allowEmpty property primefaces/primeng
1 participant
@gucal