-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowEmpty
property to SelectButton
#3973
Comments
I really cannot see how this is dubious at all, the behaviour reversal was unfortunately just wrong. All of these are logically the same: If another wording is less likely to be misinterpreted, I agree with @jnoordsij that this should be fixed as per his suggestion in #3708. |
Agreed. I had to read the code to figure out why I needed |
Agreed. Is not intuitive as it currently is labeled. Now that I know, I know, but I expected it to perform the opposite of how it does based on the naming of the prop. |
This has been adressed in #4107, by deprecating the old flag and introducing a non-ambiguous new flag. Would be great to have it merged! |
unselectable
behaviorallowEmpty
property to SelectButton
Describe the bug
In #3610 and #3708, the behavior for the
unselectable
was reversed. This is very confusing, as it is dubious wether or not this is an improvement to the logic.Moreover it certainly is a breaking change of behavior and should not have been added in a minor version update.
For further reference, please see #3708 (comment) and below.
The text was updated successfully, but these errors were encountered: