feat: allow prettier to use custom node
#3061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaakschroeder
commented
Jul 3, 2023
| import { ChildProcess, fork, ForkOptions } from "child_process"; | ||
| import { EventEmitter } from "events"; | ||
|
|
||
| export class ChildProcessWorker { |
There was a problem hiding this comment.
This class mimics Worker (with on("message", ...) and postMessage(...)) except it uses fork and node's IPC instead.
izaakschroeder
commented
Jul 3, 2023
src/PrettierWorkerInstance.ts
Outdated
| @@ -34,12 +39,19 @@ export const PrettierWorkerInstance: PrettierInstanceConstructor = class Prettie | |||
| } | |||
| > = new Map(); | |||
|
|
|||
| private worker; | |||
There was a problem hiding this comment.
Is there any problem with having a non-global worker instance?
izaakschroeder
commented
Jul 3, 2023
| }; | ||
| } | ||
|
|
||
| module.exports = (parentPort) => { |
There was a problem hiding this comment.
This function is basically just a wrapped version of the existing message handlers that were already in the file, with a small DRY'd up normalizeResult utility to avoid some existing code duplication.
This was referenced Jul 3, 2023
izaakschroeder
commented
Jul 3, 2023
Adds a `prettier.runtime` configuration option that, when used, invokes a version of `PrettierWorkerInstance` that uses `fork` instead of worker threads. Fixes: prettier#3017 Fixes: prettier#2857
izaakschroeder
force-pushed
the
childprocess
branch
from
d17fb41 to
a1b0d86
Compare
izaakschroeder
commented
Jul 5, 2023
| err.stack | ||
| ); | ||
| await worker.terminate(); | ||
| this.createWorker(); |
There was a problem hiding this comment.
TODO: Consider throttling this.
|
This pull request has been labeled as stale due to inactivity. Reply to keep this pull request open. |
dmaskasky
reviewed
Mar 12, 2024
| @@ -24,6 +24,7 @@ | |||
| "ext.config.requireConfig": "排版需要 prettier 組態檔。參閱[可用的組態檔文件](https://prettier.io/docs/en/configuration.html).\n\n> _注意，無標題檔案仍會使用 VS Code 的 prettier 設定進行排版，不受這個設定值影響。_", | |||
| "ext.config.requirePragma": "Prettier 可以限制它自己只對包含特殊註解的檔案進行排版，這個特殊的註解成為 pragma ，位於檔案的最頂部。這對於想要對那些大型、未經過排版的程式碼緩步採納 prettier 非常有幫助。", | |||
| "ext.config.resolveGlobalModules": "這個套件會在區域的模組找不到 prettier 模組時嘗試使用去全域的 npm 或 yarn 模組中尋找。\n> _這個設定會導致效能的負面影響，特別在 Windows 中有掛載網路磁碟機。只有在你必須使用全域模組的情況下再啟用。_", | |||
| "ext.config.runtime": "TODO TRANSLATE ME", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
prettier.runtimeconfiguration option that, when used, invokes a version ofPrettierWorkerInstancethat usesforkinstead of worker threads.Maybe fixes: #3017
Fixes: #2857
TODO:
prettier.runtimeis set…), but I'm happy for early feedback if this is something the maintainers are willing to consider before moving ahead.CHANGELOG.mdwith a summary of your changes