Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run with system node #2857

Open
tjx666 opened this issue Feb 2, 2023 · 1 comment
Open

Run with system node #2857

tjx666 opened this issue Feb 2, 2023 · 1 comment
Labels
enhancement

Comments

@tjx666
Copy link

tjx666 commented Feb 2, 2023

Is your feature request related to a problem? Please describe.

Like ESLint extension provide setting: "eslint.runtime": "node",, more details ref: microsoft/vscode-eslint#1233

Describe the solution you'd like

Provide setting prettier.runtime, and support pass node to auto detect system node path.
izaakschroeder added a commit to izaakschroeder/prettier-vscode that referenced this issue Jul 3, 2023
@izaakschroeder
feat: allow prettier to use custom node
ef611a6 
Adds a `prettier.runtime` configuration option that, when used, invokes a version of `PrettierWorkerInstance` that uses `fork` instead of worker threads.

Fixes: prettier#3017
Fixes: prettier#2857
izaakschroeder added a commit to izaakschroeder/prettier-vscode that referenced this issue Jul 3, 2023
@izaakschroeder
feat: allow prettier to use custom node
d17fb41 
Adds a `prettier.runtime` configuration option that, when used, invokes a version of `PrettierWorkerInstance` that uses `fork` instead of worker threads.

Fixes: prettier#3017
Fixes: prettier#2857
@izaakschroeder izaakschroeder mentioned this issue Jul 3, 2023
Closed
2 tasks
@izaakschroeder
Copy link

@tjx666 I have opened #3061 if you want to try testing out that branch. No promises, but it's a start. My first time mucking about in this codebase and VSCode extensions in general… so it would be very useful to have feedback from someone who is actually affected by this problem.

izaakschroeder added a commit to izaakschroeder/prettier-vscode that referenced this issue Jul 3, 2023
@izaakschroeder
feat: allow prettier to use custom node
a1b0d86 
Adds a `prettier.runtime` configuration option that, when used, invokes a version of `PrettierWorkerInstance` that uses `fork` instead of worker threads.

Fixes: prettier#3017
Fixes: prettier#2857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow prettier to use custom node izaakschroeder/prettier-vscode
3 participants
@izaakschroeder @ntotten @tjx666