fix: report node when loc not found #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 62005b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JounQin
reviewed
Jan 13, 2025
|
@ntnyq I can't edit the PR directly because of missing permission, so please help to add a changeset, or enable Allow edits from maintainers. |
JounQin
approved these changes
Jan 13, 2025
|
Thanks for your contribution first! Can you add a test case for it? |
Yes, I'll add the test case after I finish my lunch. |
|
Sorry I failed to add a test case for this. The original issue has mixed usage of esm and cjs syntax in I can't reproduce it in test even if I tried to add an integrated test. BTW: Allow edits by maintainers feature is enabled now. |
JounQin
force-pushed
the
fix/node-or-loc
branch
from
ccd2ece to
d6b90c1
Compare
|
@ntnyq See Thanks for your work! |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 15, 2025
##### [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 15, 2025
##### [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 17, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.2 | ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 20, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.3 | ## [v5.2.3](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#523) ##### Patch Changes - [#703](prettier/eslint-plugin-prettier#703) [`9c6141f`](prettier/eslint-plugin-prettier@9c6141f) Thanks [@BPScott](https://github.com/BPScott)! - Add name field to recommended flat config ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 24, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.3 | ## [v5.2.3](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#523) ##### Patch Changes - [#703](prettier/eslint-plugin-prettier#703) [`9c6141f`](prettier/eslint-plugin-prettier@9c6141f) Thanks [@BPScott](https://github.com/BPScott)! - Add name field to recommended flat config ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 25, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.3 | ## [v5.2.3](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#523) ##### Patch Changes - [#703](prettier/eslint-plugin-prettier#703) [`9c6141f`](prettier/eslint-plugin-prettier@9c6141f) Thanks [@BPScott](https://github.com/BPScott)! - Add name field to recommended flat config ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 26, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.3 | ## [v5.2.3](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#523) ##### Patch Changes - [#703](prettier/eslint-plugin-prettier#703) [`9c6141f`](prettier/eslint-plugin-prettier@9c6141f) Thanks [@BPScott](https://github.com/BPScott)! - Add name field to recommended flat config ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 27, 2025
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.2.1 | 5.2.3 | ## [v5.2.3](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#523) ##### Patch Changes - [#703](prettier/eslint-plugin-prettier#703) [`9c6141f`](prettier/eslint-plugin-prettier@9c6141f) Thanks [@BPScott](https://github.com/BPScott)! - Add name field to recommended flat config ## [v5.2.2](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#522) ##### Patch Changes - [#700](prettier/eslint-plugin-prettier#700) [`aa5b59f`](prettier/eslint-plugin-prettier@aa5b59f) Thanks [@ntnyq](https://github.com/ntnyq)! - fix: report node when loc not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #687.