fix(ci): Update release-notes-check and presto-release-prepare actions#27466
Merged
unidevel merged 1 commit intoprestodb:masterfrom Mar 31, 2026
Merged
fix(ci): Update release-notes-check and presto-release-prepare actions#27466unidevel merged 1 commit intoprestodb:masterfrom
unidevel merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
Waiting for prestodb/presto-release-tools#64 merged and a new version of presto-release-tools published. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate CI workflows and release script to download presto-release-tools directly from GitHub releases using a configurable RELEASE_TOOLS_VERSION (default 0.13), and ensure that version is consistently propagated across release-related jobs. Sequence diagram for updated release-notes-check workflow tool downloadsequenceDiagram
actor Developer
participant GitHub as GitHub
participant ReleaseNotesCheckWorkflow as Release_notes_check_workflow
participant Runner as GitHub_Actions_runner
participant GitHubReleases as GitHub_releases_presto_release_tools
participant PrestoReleaseTools as Presto_release_tools_executable
Developer->>GitHub: Open_or_update_pull_request
GitHub-->>ReleaseNotesCheckWorkflow: Trigger_workflow_on_pull_request
ReleaseNotesCheckWorkflow->>Runner: Start_job_check_release_note
Runner->>Runner: Set_env_RELEASE_TOOLS_VERSION
note over Runner: RELEASE_TOOLS_VERSION = vars.RELEASE_TOOLS_VERSION_or_0_13
Runner->>GitHubReleases: GET_presto_release_tools_${RELEASE_TOOLS_VERSION}
GitHubReleases-->>Runner: Download_jar_to_tmp_presto_release
Runner->>Runner: chmod_755_tmp_presto_release
Runner->>GitHub: Call_GraphQL_API_get_PR_body
GitHub-->>Runner: Return_PR_body
Runner->>PrestoReleaseTools: echo_PR_body_pipe_to_tmp_presto_release_check_release_notes
PrestoReleaseTools-->>Runner: Validation_result
Runner-->>ReleaseNotesCheckWorkflow: Mark_job_success_or_failure
ReleaseNotesCheckWorkflow-->>GitHub: Report_status_on_pull_request
Flow diagram for RELEASE_TOOLS_VERSION resolution across CI and scriptflowchart TD
A[GitHub_repository_variable_vars.RELEASE_TOOLS_VERSION] --> B{vars.RELEASE_TOOLS_VERSION_set?}
B -- Yes --> C[Workflow_env_RELEASE_TOOLS_VERSION = vars.RELEASE_TOOLS_VERSION]
B -- No --> D[Workflow_env_RELEASE_TOOLS_VERSION = 0.13]
C --> E[Job_env_in_release_notes_check_and_presto_release_prepare]
D --> E
E --> F[Step_env_RELEASE_TOOLS_VERSION_exported_to_runner]
F --> G[Script_release_notes.sh_env_RECEIVES_RELEASE_TOOLS_VERSION]
G --> H{Script_env_RELEASE_TOOLS_VERSION_set?}
H -- Yes --> I[Script_uses_existing_RELEASE_TOOLS_VERSION]
H -- No --> J[Script_sets_RELEASE_TOOLS_VERSION = 0.13]
I --> K[curl_download_from_GitHub_releases_using_RELEASE_TOOLS_VERSION]
J --> K
K --> L[java_runs_presto_release_tools_with_release_notes_command]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/release-notes-check.yml" line_range="8" />
<code_context>
MAVEN_OPTS: ${{ vars.MAVEN_OPTS }}
GIT_CI_USER: ${{ vars.GIT_CI_USER || 'prestodb-ci' }}
GIT_CI_EMAIL: ${{ vars.GIT_CI_EMAIL || 'ci@lists.prestodb.io' }}
+ RELEASE_TOOLS_VERSION: ${{ vars.RELEASE_TOOLS_VERSION || '0.13' }}
+
</code_context>
<issue_to_address>
**suggestion:** Avoid duplicating the default release tools version in multiple places to prevent future drift.
The default `RELEASE_TOOLS_VERSION` (`0.13`) is hard-coded both in the GitHub Actions env (`vars.RELEASE_TOOLS_VERSION || '0.13'`) and in `release-notes.sh` (`${RELEASE_TOOLS_VERSION:-"0.13"}`). Consider having a single source of truth (e.g., default only in the workflow or only in the script) and let the other inherit the value to avoid future drift.
Suggested implementation:
```
env:
RELEASE_TOOLS_VERSION: ${{ vars.RELEASE_TOOLS_VERSION }}
```
No other workflow changes are strictly required, assuming `release-notes.sh` already defines `RELEASE_TOOLS_VERSION` with a default using `${RELEASE_TOOLS_VERSION:-"0.13"}`. If that default is removed or changed in the script, this workflow will now respect that new single source of truth.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tdcmeehan
previously approved these changes
Mar 31, 2026
71ef17a to
a9d514e
Compare
a9d514e to
bf5bdfd
Compare
tdcmeehan
approved these changes
Mar 31, 2026
Contributor
tdcmeehan
left a comment
There was a problem hiding this comment.
Good to have this validation
bibith4
pushed a commit
to bibith4/presto
that referenced
this pull request
Apr 1, 2026
prestodb#27466) ## Description 1. presto-release-tools can not be fetched due to maven central publishing limitation 2. check maven central publishing requirements 3. add required `<name>` field to presto-lance ## Motivation and Context Depends on PRs: - prestodb/presto-release-tools#65 - prestodb/presto-release-tools#64 - prestodb/presto-release-tools#63 - prestodb/presto-release-tools#62 ## Impact CI ## Test Plan Tested with: 1. release note check action: https://github.com/prestodb/presto/actions/runs/23815800338/job/69414865062?pr=27466 2. maven central publishing requirements check: https://github.com/unix280/presto/actions/runs/23812452401/job/69402863222#step:8:76 3. Prepare release action in presto => https://github.com/unix280/presto/actions/runs/23812844511 4. Release notes PR => unix280#52 5. Release notes missing list file => https://github.com/unix280/presto/blob/release-notes-0.297/release-notes-missing-0.297.md ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Update CI and release scripts to retrieve presto-release-tools from GitHub releases using a configurable version instead of Maven Central. CI: - Change release-notes-check workflow to download the presto-release-tools executable directly from GitHub releases and run it from a temporary path. - Make the release-notes-check workflow use a configurable RELEASE_TOOLS_VERSION with a default of 0.13. Deployment: - Update release preparation workflow and release-notes script to use a configurable RELEASE_TOOLS_VERSION (default 0.13) and fetch presto-release-tools from GitHub releases instead of Maven. Chores: - Align release tooling version and retrieval method across CI workflows and release scripts.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<name>field to presto-lanceMotivation and Context
Depends on PRs:
Impact
CI
Test Plan
Tested with:
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Update CI and release scripts to retrieve presto-release-tools from GitHub releases using a configurable version instead of Maven Central.
CI:
Deployment:
Chores: