[fix] Update the re pattern for the release notes section

[yhwang]

Since the description may contain the Summary by Sourcery at the end, adjust the re pattern to accommondate this situation. The negative lookahead (?!\nSummary by) only stops when it encounters "\nSummary by". If that pattern doesn't exist, it continues to the end just like the old pattern.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the regex used to extract release notes so that it stops before an optional trailing "Summary by Sourcery" section and adds a regression test with a new fixture covering this scenario.

Class diagram for updated release note pattern in GenerateReleaseNotesTask

classDiagram
    class GenerateReleaseNotesTask {
        <<task>>
        - static Pattern IGNORED_COMMITS_PATTERN
        # static Pattern NO_RELEASE_NOTE_PATTERN
        # static Pattern RELEASE_NOTE_PATTERN
        - static Pattern HEADER_PATTERN
        + void execute()
        + String extractReleaseNotes(String commitMessage)
    }

    class TestCheckReleaseNotesTask {
        <<test>>
        + void testReleaseNotesWithTrailingSummary()
        + void testNoReleaseNotes()
        + void testValidReleaseNotes()
    }

    class Pattern {
        <<java_util_regex>>
        + matcher(String input) Matcher
    }

    GenerateReleaseNotesTask --> Pattern : uses
    TestCheckReleaseNotesTask --> GenerateReleaseNotesTask : tests

Loading

File-Level Changes

Change	Details	Files
Refine release note extraction pattern to ignore trailing "Summary by" content.	Update RELEASE_NOTE_PATTERN to require a newline after the header before capturing content. Use a tempered dot/negative lookahead so matching stops before a line starting with "Summary by" if present. Preserve multiline and dotall behavior so the pattern still captures multi-line release notes when no summary is present.	presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java
Extend tests to cover release notes with trailing content.	Register a new release-notes test fixture that includes trailing content after the release notes section. Ensure CheckReleaseNotesTask treats the new fixture as valid, confirming the updated regex behavior.	presto-release-tools/src/test/java/com/facebook/presto/release/tasks/TestCheckReleaseNotesTask.java presto-release-tools/src/test/resources/release-notes-test/pr/release_notes_with_trailing_content.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The updated RELEASE_NOTE_PATTERN now hard-requires a newline after == release note(s)? == (\w*\n), whereas the previous pattern also handled content that continued on the same line; consider making the newline optional so existing one-line release note formats continue to match.
• The new regex with the negative lookahead for \nSummary by is quite dense; consider extracting the pattern into a named constant or adding a brief code comment explaining the intent (stop capture before the Summary by Sourcery footer while still consuming to EOF if absent) to aid future maintainers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The updated `RELEASE_NOTE_PATTERN` now hard-requires a newline after `== release note(s)? ==` (`\w*\n`), whereas the previous pattern also handled content that continued on the same line; consider making the newline optional so existing one-line release note formats continue to match.
- The new regex with the negative lookahead for `\nSummary by` is quite dense; consider extracting the pattern into a named constant or adding a brief code comment explaining the intent (stop capture before the `Summary by Sourcery` footer while still consuming to EOF if absent) to aid future maintainers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[yhwang]

Hey - I've left some high level feedback:

• The updated RELEASE_NOTE_PATTERN now hard-requires a newline after == release note(s)? == (\w*\n), whereas the previous pattern also handled content that continued on the same line; consider making the newline optional so existing one-line release note formats continue to match.
• The new regex with the negative lookahead for \nSummary by is quite dense; consider extracting the pattern into a named constant or adding a brief code comment explaining the intent (stop capture before the Summary by Sourcery footer while still consuming to EOF if absent) to aid future maintainers.

addressed these two items in the changes.

[yhwang]

cc @tdcmeehan

[steveburnett]

Here's another, different failure:

https://github.com/prestodb/presto/actions/runs/23629090536/job/68824276560?pr=27422

Bad release notes for PR #0: expect section header, found [Differential Revision: D97920227]

in prestodb/presto#27422

[steveburnett]

Also affecting
prestodb/presto#27266

[yhwang]

@tdcmeehan, not sure what the next step is?
Have a new version of the presto-release-tools, publish, and update the dep of the presto repo?

[tdcmeehan]

Yes, @unidevel can help

[unidevel]

Sure, let me publish presto-release-tools first.

[unidevel]

Failed, due to the maven central publising limitation, we can't publish this as executable jars.

 - Failed to process deployment: Error on building manifests: Unable to parse archive Details: Executable bundles are not supported. For Spring Boot applications, see: https://docs.spring.io/spring-boot/gradle-plugin/packaging.html#packaging-executable.configuring.launch-script

[unidevel]

I will add a PR to publish executable jars to github, and we can then update related script to download it from github.

[unidevel]

Created PR #63