fix(ci): Skip arrowflight CI for doc-only changes#27285
Merged
yhwang merged 1 commit intoprestodb:masterfrom Mar 8, 2026
Merged
fix(ci): Skip arrowflight CI for doc-only changes#27285yhwang merged 1 commit intoprestodb:masterfrom
yhwang merged 1 commit intoprestodb:masterfrom
Conversation
Use the same mechanism to check the doc-only changes on the arrow flight CI tasks Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Contributor
Reviewer's GuideUpdates the arrow flight GitHub Actions workflow to dynamically skip all arrow flight CI jobs when a pull request only modifies documentation (presto-docs/**), by introducing a shared path-filter job and gating all expensive jobs on its output. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of adding
if: needs.changes.outputs.codechange == 'true'to every step, consider putting this condition at the job level for the Arrow Flight jobs so that runners are not allocated at all for doc-only PRs and the workflow YAML stays simpler. - Given that the jobs already
needs: changes, you can likely drop redundant per-stepifconditions for steps that are the only work in the job, relying on the job-level gating to avoid unnecessary execution.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of adding `if: needs.changes.outputs.codechange == 'true'` to every step, consider putting this condition at the job level for the Arrow Flight jobs so that runners are not allocated at all for doc-only PRs and the workflow YAML stays simpler.
- Given that the jobs already `needs: changes`, you can likely drop redundant per-step `if` conditions for steps that are the only work in the job, relying on the job-level gating to avoid unnecessary execution.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
pratyakshsharma
approved these changes
Mar 8, 2026
Contributor
pratyakshsharma
left a comment
There was a problem hiding this comment.
Looks good to me. Couple of my docs-only PRs are stuck, will want to verify this after it is merged. Thanks
tdcmeehan
approved these changes
Mar 8, 2026
Member
Author
|
@pratyakshsharma @tdcmeehan Thanks for the prompt review. |
This was referenced Mar 9, 2026
Contributor
|
@yhwang The fix worked for my PRs. Thank you so much. |
7 tasks
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the same mechanism to check the doc-only changes on the arrow flight CI tasks
Motivation and Context
Some doc-only PRs are blocked by arrow flight CI tasks. Need to make arrow flight CI tasks optional for doc-only PRs.
Impact
Doc-only PRs can skip arrow flight tests
Test Plan
Copy the same mechanism to the arrow flight workflow. So this has been proven and worked. Further verification is needed after this PR is merged. Check if doc-only PRs skip arrow flight tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
CI: