Skip to content

fix(ci): Skip arrowflight CI for doc-only changes#27285

Merged
yhwang merged 1 commit intoprestodb:masterfrom
yhwang:fix-doc-only-ci-4-arrow-flight-tests
Mar 8, 2026
Merged

fix(ci): Skip arrowflight CI for doc-only changes#27285
yhwang merged 1 commit intoprestodb:masterfrom
yhwang:fix-doc-only-ci-4-arrow-flight-tests

Conversation

@yhwang
Copy link
Copy Markdown
Member

@yhwang yhwang commented Mar 6, 2026

Description

Use the same mechanism to check the doc-only changes on the arrow flight CI tasks

Motivation and Context

Some doc-only PRs are blocked by arrow flight CI tasks. Need to make arrow flight CI tasks optional for doc-only PRs.

Impact

Doc-only PRs can skip arrow flight tests

Test Plan

Copy the same mechanism to the arrow flight workflow. So this has been proven and worked. Further verification is needed after this PR is merged. Check if doc-only PRs skip arrow flight tests.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

CI:

  • Introduce a paths-filter job and wire Arrow Flight test jobs to run only when changes are not limited to presto-docs, allowing doc-only PRs to bypass these workflows.

Use the same mechanism to check the doc-only changes
on the arrow flight CI tasks

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@yhwang yhwang requested review from a team, czentgr and unidevel as code owners March 6, 2026 22:37
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 6, 2026
@prestodb-ci prestodb-ci requested review from a team and nmahadevuni and removed request for a team March 6, 2026 22:37
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 6, 2026

Reviewer's Guide

Updates the arrow flight GitHub Actions workflow to dynamically skip all arrow flight CI jobs when a pull request only modifies documentation (presto-docs/**), by introducing a shared path-filter job and gating all expensive jobs on its output.

File-Level Changes

Change Details Files
Introduce a paths-filter job and gate all arrow flight jobs so they are skipped for doc-only pull requests.
  • Change workflow trigger from path-ignored pull_request to a plain pull_request event to ensure the workflow still runs on doc-only changes.
  • Add a new 'changes' job using dorny/paths-filter to compute a 'codechange' output that is false when only presto-docs/** files are touched.
  • Add 'needs: changes' dependencies for all arrow flight jobs so they can see the filter result.
  • Guard all checkout, build, install, test, artifact-upload, and related steps in arrowflight-java-tests, prestocpp-linux-build-for-test, and arrowflight-native-e2e-tests with an 'if: needs.changes.outputs.codechange == "true"' condition so they no-op on doc-only PRs.
  • Update the dependency graph for arrowflight-native-e2e-tests to depend on both the new changes job and the prestocpp-linux-build-for-test job.
.github/workflows/arrow-flight-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of adding if: needs.changes.outputs.codechange == 'true' to every step, consider putting this condition at the job level for the Arrow Flight jobs so that runners are not allocated at all for doc-only PRs and the workflow YAML stays simpler.
  • Given that the jobs already needs: changes, you can likely drop redundant per-step if conditions for steps that are the only work in the job, relying on the job-level gating to avoid unnecessary execution.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of adding `if: needs.changes.outputs.codechange == 'true'` to every step, consider putting this condition at the job level for the Arrow Flight jobs so that runners are not allocated at all for doc-only PRs and the workflow YAML stays simpler.
- Given that the jobs already `needs: changes`, you can likely drop redundant per-step `if` conditions for steps that are the only work in the job, relying on the job-level gating to avoid unnecessary execution.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@pratyakshsharma pratyakshsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Couple of my docs-only PRs are stuck, will want to verify this after it is merged. Thanks

@yhwang yhwang merged commit 25d2fb1 into prestodb:master Mar 8, 2026
85 of 87 checks passed
@yhwang yhwang deleted the fix-doc-only-ci-4-arrow-flight-tests branch March 8, 2026 16:56
@yhwang
Copy link
Copy Markdown
Member Author

yhwang commented Mar 8, 2026

@pratyakshsharma @tdcmeehan Thanks for the prompt review.
@pratyakshsharma Can you rebase and try the change on your doc-only PRs? Thanks

@pratyakshsharma
Copy link
Copy Markdown
Contributor

@yhwang The fix worked for my PRs. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants