docs: Add limitation for spatial_partitioning and spatial_partitions#27242
docs: Add limitation for spatial_partitioning and spatial_partitions#27242steveburnett merged 1 commit intoprestodb:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocuments newly discovered limitations of the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="presto-docs/src/main/sphinx/presto_cpp/limitations.rst" line_range="342" />
<code_context>
Note: ``TIMESTAMP`` behavior in Presto and Presto C++ is unchanged.
-For examples, consider the following queries and their responses when run in Presto:
+For examples, consider the following queries and their responses when run in Presto:
</code_context>
<issue_to_address>
**suggestion (typo):** Adjust "For examples" to the more idiomatic "For example".
"For examples, consider" is unidiomatic. Please change to `For example, consider the following queries and their responses when run in Presto:` or simply `For example:`.
```suggestion
For example, consider the following queries and their responses when run in Presto:
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Just a nit about linking, see what you can do.
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
|
|
||
| Due to its internal nature, lack of documentation, limited usage, and incompatibility | ||
| with Presto's streaming architecture, this function was not implemented in Presto C++. | ||
| Standard spatial join operations should be used instead. |
There was a problem hiding this comment.
Maybe mention which these actually are or have a link to documentation.
There was a problem hiding this comment.
Updated, thank you!
|
@steveburnett Thank you, updated! |
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the updated doc! Looks good, just one nit.
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
Description
docs: Add limitation docs for spatial_partitioning and spatial_partitions
Motivation and Context
As part of facebookincubator/velox#16041
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Document limitations of the
spatial_partitioningandspatial_partitionsfeatures in the Presto C++ limitations guide.Documentation:
spatial_partitioningin the Presto C++ engine.spatial_partitionsin the Presto C++ engine.