Skip to content

docs: Add limitation for spatial_partitioning and spatial_partitions#27242

Merged
steveburnett merged 1 commit intoprestodb:masterfrom
jkhaliqi:limitations
Mar 19, 2026
Merged

docs: Add limitation for spatial_partitioning and spatial_partitions#27242
steveburnett merged 1 commit intoprestodb:masterfrom
jkhaliqi:limitations

Conversation

@jkhaliqi
Copy link
Copy Markdown
Contributor

@jkhaliqi jkhaliqi commented Mar 2, 2026

Description

docs: Add limitation docs for spatial_partitioning and spatial_partitions

Motivation and Context

As part of facebookincubator/velox#16041

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Document limitations of the spatial_partitioning and spatial_partitions features in the Presto C++ limitations guide.

Documentation:

  • Add documentation describing the limitations of spatial_partitioning in the Presto C++ engine.
  • Add documentation describing the limitations of spatial_partitions in the Presto C++ engine.

@jkhaliqi jkhaliqi requested review from a team, elharo and steveburnett as code owners March 2, 2026 16:48
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 2, 2026
@prestodb-ci prestodb-ci requested review from a team, imsayari404 and libianoss and removed request for a team March 2, 2026 16:48
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Documents newly discovered limitations of the spatial_partitioning and spatial_partitions features in the Presto C++ engine by updating the Presto CPP limitations documentation page.

File-Level Changes

Change Details Files
Document limitations of spatial partitioning features in Presto C++ engine docs.
  • Add a subsection describing constraints and unsupported scenarios for the spatial_partitioning session property or feature.
  • Add a subsection describing constraints and unsupported scenarios for the spatial_partitions feature or configuration option.
  • Clarify any behavioral differences or caveats between the Java and C++ engines for these spatial partitioning capabilities, if applicable.
presto-docs/src/main/sphinx/presto_cpp/limitations.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="presto-docs/src/main/sphinx/presto_cpp/limitations.rst" line_range="342" />
<code_context>

 Note: ``TIMESTAMP`` behavior in Presto and Presto C++ is unchanged.

-For examples, consider the following queries and their responses when run in Presto: 
+For examples, consider the following queries and their responses when run in Presto:

</code_context>
<issue_to_address>
**suggestion (typo):** Adjust "For examples" to the more idiomatic "For example".

"For examples, consider" is unidiomatic. Please change to `For example, consider the following queries and their responses when run in Presto:` or simply `For example:`.

```suggestion
For example, consider the following queries and their responses when run in Presto:
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Just a nit about linking, see what you can do.

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to 🏗 In progress in Presto Documentation Mar 3, 2026
steveburnett
steveburnett previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Mar 5, 2026
allenshen13
allenshen13 previously approved these changes Mar 12, 2026

Due to its internal nature, lack of documentation, limited usage, and incompatibility
with Presto's streaming architecture, this function was not implemented in Presto C++.
Standard spatial join operations should be used instead.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention which these actually are or have a link to documentation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thank you!

@steveburnett
Copy link
Copy Markdown
Contributor

@yhwang recently updated the CI check for doc-only PRs to skip the arrowflight CI check, see #27285.

Rebase this PR and the CI checks should all clear.

@jkhaliqi
Copy link
Copy Markdown
Contributor Author

@steveburnett Thank you, updated!

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated doc! Looks good, just one nit.

@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Presto Documentation Mar 16, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Mar 18, 2026
Copy link
Copy Markdown
Contributor

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@steveburnett steveburnett merged commit dd52621 into prestodb:master Mar 19, 2026
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs from:IBM PR from IBM

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants