Skip to content

fix(spi): Typo in the comment of MaterializedViewDefinition.TableColumn #27172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Feb 19, 2026
Merged

fix(spi): Typo in the comment of MaterializedViewDefinition.TableColumn #27172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-spi/src/main/java/com/facebook/presto/spi/MaterializedViewDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ public static final class TableColumn
private final String columnName;
// This signifies whether the mapping is direct or not.
// Mapping is always direct in inner join case. In the outer join case, only the mapping from a column to its source column in the join input table is direct.
// For e.g. in case of SELECT t1_a as t1.a, t2_a as t2.a FROM t1 LEFT JOIN t2 ON t1.a = t2.a
// For e.g. in case of SELECT t1.a as t1_a, t2.a as t2_a FROM t1 LEFT JOIN t2 ON t1.a = t2.a
// t1_a -> t1.a is direct mapped
// t1_a -> t2.a is NOT direct mapped(as t1,t2 are in outer join)
// t2_a -> t2.a is direct mapped(value can become null but column mapping is not altered)
Expand Down
Loading