Skip to content

fix(spi): Typo in the comment of MaterializedViewDefinition.TableColumn#27172

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
hantangwangd:fix_typo
Feb 19, 2026
Merged

fix(spi): Typo in the comment of MaterializedViewDefinition.TableColumn#27172
tdcmeehan merged 1 commit intoprestodb:masterfrom
hantangwangd:fix_typo

Conversation

@hantangwangd
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd commented Feb 19, 2026

Description

This PR fix a typo in the comment of MaterializedViewDefinition.TableColumn. The correct SQL grammar should be:

SELECT t1.a as t1_a, t2.a as t2_a FROM t1 LEFT JOIN t2 ON t1.a = t2.a

Previously it was incorrectly written as:

SELECT t1_a as t1.a, t2_a as t2.a FROM t1 LEFT JOIN t2 ON t1.a = t2.a

Motivation and Context

N/A

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Documentation:

  • Fix incorrect SQL example in MaterializedViewDefinition.TableColumn Javadoc comment to reflect proper alias usage.

@hantangwangd hantangwangd requested a review from a team as a code owner February 19, 2026 11:00
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrects example SQL in a comment on MaterializedViewDefinition.TableColumn to use valid column aliasing, aligning the documentation with the actual join semantics; no functional or behavioral code changes.

File-Level Changes

Change Details Files
Fix SQL example in TableColumn comment to use correct aliasing for LEFT JOIN column mapping description.
  • Update the SELECT example to alias table columns to output column names instead of the reverse.
  • Keep the surrounding explanation of direct vs non-direct mappings unchanged, only adjusting the example to match the described semantics.
presto-spi/src/main/java/com/facebook/presto/spi/MaterializedViewDefinition.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tdcmeehan tdcmeehan changed the title fix: Fix typo in the comment of MaterializedViewDefinition.TableColumn fix(spi): Typo in the comment of MaterializedViewDefinition.TableColumn Feb 19, 2026
@tdcmeehan tdcmeehan merged commit 82a1939 into prestodb:master Feb 19, 2026
114 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants