fix(native): Fix protocol generation#26956
Merged
pdabre12 merged 1 commit intoprestodb:masterfrom Jan 13, 2026
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates native Iceberg protocol enums and JSON mapping to include the new METADATA_LOG_ENTRIES table type, aligning native protocol generation with recent upstream changes. Class diagram for updated IcebergTableType enum and JSON mappingclassDiagram
class IcebergTableType {
<<enumeration>>
TABLE
PARTITIONS
FILES
REFS
METADATA_LOG_ENTRIES
PROPERTIES
CHANGELOG
EQUALITY_DELETES
}
class IcebergTableType_enum_table {
+IcebergTableType key
+json value
}
IcebergTableType_enum_table --> IcebergTableType : maps
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tdcmeehan
approved these changes
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `presto-native-execution/presto_cpp/presto_protocol/connector/iceberg/presto_protocol_iceberg.cpp:460` </location>
<code_context>
{IcebergTableType::PARTITIONS, "PARTITIONS"},
{IcebergTableType::FILES, "FILES"},
{IcebergTableType::REFS, "REFS"},
+ {IcebergTableType::METADATA_LOG_ENTRIES, "METADATA_LOG_ENTRIES"},
{IcebergTableType::PROPERTIES, "PROPERTIES"},
{IcebergTableType::CHANGELOG, "CHANGELOG"},
</code_context>
<issue_to_address>
**issue (review_instructions):** The new IcebergTableType enumerator METADATA_LOG_ENTRIES should follow kPascalCase naming instead of UPPER_SNAKE_CASE.
Per the guidelines, enumerators should use kPascalCase (e.g., kMetadataLogEntries). Even though existing values in this enum use UPPER_SNAKE_CASE, new additions should follow the current convention unless there is an explicit decision to keep the legacy style here.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `presto-native-execution/**/*.hpp,presto-native-execution/**/*.cpp`
**Instructions:**
Use kPascalCase for static constants and enumerators.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix protocol generation after changes introduced by #24302 by running the
make presto_protocolcommand.Impact
No impact
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.