feat(plugin-iceberg): Add Iceberg metadata table $metadata_log_entries by agrawalreetika · Pull Request #24302 · prestodb/presto

agrawalreetika · 2024-12-29T05:45:44Z

Description

Add Iceberg metadata table $metadata_log_entries

Motivation and Context

Add Iceberg metadata table $metadata_log_entries
This will help to get metadata changes on the Iceberg table https://iceberg.apache.org/docs/latest/spark-queries/#metadata-log-entries

Impact

Iceberg Connector

Test Plan

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Connector Changes
* Add Iceberg metadata table $metadata_log_entries :pr:`24302`

hantangwangd

Thanks for adding this feature, overall looks good to me, except one little problem about timestamp with tz and some nits.

hantangwangd · 2025-01-01T16:59:34Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+            .add(new ColumnMetadata("timestamp", TIMESTAMP_WITH_TIME_ZONE))
+            .add(new ColumnMetadata("file", VARCHAR))
+            .add(new ColumnMetadata("latest_snapshot_id", BIGINT))
+            .add(new ColumnMetadata("latest_schema_id", BIGINT))


nit: Should this type be INTEGER?

hantangwangd · 2025-01-01T17:00:20Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+    {
+        InMemoryRecordSet.Builder table = InMemoryRecordSet.builder(COLUMNS);
+
+        TableMetadata metadata = ((org.apache.iceberg.BaseTable) icebergTable).operations().current();


nit: use static import

hantangwangd · 2025-01-01T17:06:15Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+            Long snapshotId = null;
+            Snapshot snapshot = null;
+            try {
+                snapshotId = SnapshotUtil.snapshotIdAsOfTime(icebergTable, entry.timestampMillis());


Suggested change

snapshotId = SnapshotUtil.snapshotIdAsOfTime(icebergTable, entry.timestampMillis());

snapshotId = snapshotIdAsOfTime(icebergTable, entry.timestampMillis());

nit: I know this code is from iceberg lib, but we can still use static import as much as possible.

hantangwangd · 2025-01-01T17:12:18Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+
+    private void addRow(InMemoryRecordSet.Builder table, ConnectorSession session, long timestampMillis, String fileLocation, Long snapshotId, Snapshot snapshot)
+    {
+        table.addRow(packDateTimeWithZone(timestampMillis, session.getSqlFunctionProperties().getTimeZoneKey()),


Should we consider the situation when session.getSqlFunctionProperties().isLegacyTimestamp() is false? As I understand, in that case we should use UTC as time zone key. Any misunderstanding please let me know.

Thanks for your review @hantangwangd

Currently with and w/o isLegacyTimestamp the output for timestamp in metadata_log_entries entries looks same -

presto:iceberg_schema> set session legacy_timestamp=true; SET SESSION presto:iceberg_schema> select * from "region_legacy$metadata_log_entries"; timestamp | file | latest_snapshot_id | latest_schema_id | latest_s> --------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------+---------> 2025-01-02 22:39:00.666 Asia/Kolkata | hdfs://localhost:9000/user/hive/warehouse/iceberg_schema.db/region_legacy/metadata/00000-26e6389a-ab54-455b-b5ce-6648e241ce29.metadata.json | 7341611993609958569 | 0 | > 2025-01-02 22:39:12.478 Asia/Kolkata | hdfs://localhost:9000/user/hive/warehouse/iceberg_schema.db/region_legacy/metadata/00001-15c85566-fcf1-413d-8115-5fc4376426cf.metadata.json | 8958386941531340808 | 0 | > (2 rows)

presto:iceberg_schema> set session legacy_timestamp=false; SET SESSION presto:iceberg_schema> select * from "region_nolegacy$metadata_log_entries"; timestamp | file | latest_snapshot_id | latest_schema_id | latest> --------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------+-------> 2025-01-02 22:40:50.877 Asia/Kolkata | hdfs://localhost:9000/user/hive/warehouse/iceberg_schema.db/region_nolegacy/metadata/00000-1de7672a-8a9e-4249-afe8-d526b094ca57.metadata.json | 1517277585224920583 | 0 | > 2025-01-02 22:41:03.948 Asia/Kolkata | hdfs://localhost:9000/user/hive/warehouse/iceberg_schema.db/region_nolegacy/metadata/00001-8bf52dfe-2601-4ce8-bb3c-30ac435573ea.metadata.json | 2705037583472111886 | 0 | > (2 rows)

It looks like both cases are taking up my local time and timezone since the session object has local TZ
Could you please help me understand if this is not expected?

My mistake, I confused the result column type timestamp with tz with timestamp. The property isLegacyTimestamp is used for timestamp type, so there is no need to consider it here.

hantangwangd · 2025-01-01T17:18:43Z

presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java

+    @Test
+    public void testMetadataLogTable()
+    {
+        try {
+            assertUpdate("CREATE TABLE test_table_metadatalog (id1 BIGINT, id2 BIGINT)");
+            assertQuery("SELECT count(*) FROM \"test_table_metadatalog$metadata_log_entries\"", "VALUES 1");
+            //metadata file created at table creation
+            assertQuery("SELECT latest_snapshot_id FROM \"test_table_metadatalog$metadata_log_entries\"", "VALUES NULL");
+
+            assertUpdate("INSERT INTO test_table_metadatalog VALUES (0, 00), (1, 10), (2, 20)", 3);
+            Table icebergTable = loadTable("test_table_metadatalog");
+            Snapshot latestSnapshot = icebergTable.currentSnapshot();
+            assertQuery("SELECT count(*) FROM \"test_table_metadatalog$metadata_log_entries\"", "VALUES 2");
+            assertQuery("SELECT latest_snapshot_id FROM \"test_table_metadatalog$metadata_log_entries\" order by timestamp DESC limit 1", "values " + latestSnapshot.snapshotId());
+        }
+        finally {
+            assertUpdate("DROP TABLE IF EXISTS test_table_metadatalog");
+        }
+    }


Is it convenient to add some test cases considering different timezone and legacyTimestamp, and verify the output column timestamp?

@hantangwangd Could you please provide me some example around which type of testcases would fit in here considering different timezone?
I just looked at other metadata tables with timestamp column, but couldn't find any example around same.

Refer to Iceberg's test case, I think we can add some tests similar with the following code:

Session session = sessionWithTimezone(zoneId); assertUpdate(session, "CREATE TABLE test_table_metadatalog (id1 BIGINT, id2 BIGINT)"); assertQuery(session, "SELECT count(*) FROM \"test_table_metadatalog$metadata_log_entries\"", "VALUES 1"); Table icebergTable = loadTable("test_table_metadatalog"); TableMetadata tableMetadata = ((HasTableOperations) icebergTable).operations().current(); ZonedDateTime zonedDateTime1 = ZonedDateTime.ofInstant(Instant.ofEpochMilli(tableMetadata.lastUpdatedMillis()), ZoneId.of(zoneId)); String metadataFileLocation1 = "file:" + tableMetadata.metadataFileLocation(); assertUpdate(session, "INSERT INTO test_table_metadatalog VALUES (0, 00), (1, 10), (2, 20)", 3); tableMetadata = ((HasTableOperations) icebergTable).operations().refresh(); ZonedDateTime zonedDateTime2 = ZonedDateTime.ofInstant(Instant.ofEpochMilli(tableMetadata.lastUpdatedMillis()), ZoneId.of(zoneId)); String metadataFileLocation2 = "file:" + tableMetadata.metadataFileLocation(); Snapshot latestSnapshot = tableMetadata.currentSnapshot(); MaterializedResult result = getQueryRunner().execute(session, "SELECT * FROM \"test_table_metadatalog$metadata_log_entries\""); assertThat(result).hasSize(2); assertThat(result) .anySatisfy(row -> assertThat(row) .isEqualTo(new MaterializedRow(MaterializedResult.DEFAULT_PRECISION, zonedDateTime1, metadataFileLocation1, null, null, null))) .anySatisfy(row -> assertThat(row) .isEqualTo(new MaterializedRow(MaterializedResult.DEFAULT_PRECISION, zonedDateTime2, metadataFileLocation2, latestSnapshot.snapshotId(), latestSnapshot.schemaId(), latestSnapshot.sequenceNumber())));

And test it under different zoneIds.

ZacBlanco

One minor thing. I also agree with @hantanwangd to make sure this works with proper TZ configuration. Otherwise lgtm

ZacBlanco · 2025-01-03T17:09:01Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+    @Override
+    public RecordCursor cursor(ConnectorTransactionHandle transactionHandle, ConnectorSession session, TupleDomain<Integer> constraint)
+    {
+        InMemoryRecordSet.Builder table = InMemoryRecordSet.builder(COLUMNS);


Rather than use the builder, I would recommend using the public constructor and passing an iterator. It will help reduce memory pressure on the coordinator by streaming records rather than requiring us to aggregate all at once in-memory. The overall footprint of this table shouldn't be too large but I think using an iterator approach to generate the records is not difficult to implement.

When generating records you can just use java's Stream and map operations and just call .iterator() at the end.

ZacBlanco · 2025-01-03T17:10:59Z

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

+        List<MetadataLogEntry> metadataLogEntries = metadata.previousFiles();
+
+        processMetadataLogEntries(table, session, metadataLogEntries);
+        addLatestMetadataEntry(table, session, metadata);


to add the latest entry I think you can just do Stream.concat+Stream.of()

steveburnett

LGTM! (docs)

Pull branch, local doc build, looks good. Thank you for the documentation!

sourcery-ai · 2025-12-04T12:37:14Z

Reviewer's Guide

Implements the Iceberg $metadata_log_entries system table and wires it into the connector, exposing metadata log history (with timestamps, file paths, and snapshot details) and adding tests including time-zone sensitive behavior and documentation hooks.

Sequence diagram for querying the Iceberg $metadata_log_entries system table

sequenceDiagram
    actor User
    participant PrestoEngine
    participant IcebergMetadata as IcebergAbstractMetadata
    participant MetadataLogTable
    participant BaseTable
    participant TableOperations
    participant TableMetadata

    User->>PrestoEngine: SELECT * FROM table$metadata_log_entries
    PrestoEngine->>IcebergMetadata: getIcebergSystemTable(tableName, icebergTable)
    IcebergMetadata->>IcebergMetadata: resolve IcebergTableType METADATA_LOG_ENTRIES
    IcebergMetadata-->>PrestoEngine: new MetadataLogTable(systemTableName, icebergTable)

    PrestoEngine->>MetadataLogTable: cursor(transactionHandle, session, constraint)

    MetadataLogTable->>BaseTable: operations()
    BaseTable-->>MetadataLogTable: TableOperations
    MetadataLogTable->>TableOperations: current()
    TableOperations-->>MetadataLogTable: TableMetadata

    loop for each previousFiles entry
        MetadataLogTable->>TableMetadata: previousFiles()
        TableMetadata-->>MetadataLogTable: iterator of MetadataLogEntry
        MetadataLogTable->>MetadataLogTable: processMetadataLogEntries(session, metadataLogEntry)
    end

    MetadataLogTable->>TableMetadata: lastUpdatedMillis(), metadataFileLocation()
    TableMetadata-->>MetadataLogTable: timestampMillis, fileLocation

    MetadataLogTable->>BaseTable: operations().current()
    BaseTable-->>MetadataLogTable: TableMetadata (current)
    MetadataLogTable->>MetadataLogTable: buildLatestMetadataRow(session, currentMetadata)

    MetadataLogTable-->>PrestoEngine: RecordCursor over metadata log rows
    PrestoEngine-->>User: result set (timestamp, file, latest_snapshot_id, latest_schema_id, latest_sequence_number)

File-Level Changes

Change	Details	Files
Introduce MetadataLogTable system table implementation to expose Iceberg metadata log entries with timestamp, file, and snapshot metadata columns.	Define MetadataLogTable implementing SystemTable with fixed column metadata and types for timestamp, file path, latest snapshot id, schema id, and sequence number. Implement cursor() using an iterator over Iceberg TableMetadata.previousFiles() plus a synthesized latest metadata entry. Convert Iceberg metadata timestamps to TIMESTAMP WITH TIME ZONE using the session time zone and derive snapshot metadata via snapshotIdAsOfTime and currentSnapshot().	`presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java`
Register the new $metadata_log_entries system table in the Iceberg connector metadata and table naming logic.	Extend IcebergTableType enum with METADATA_LOG_ENTRIES marked as a system table. Add METADATA_LOG_ENTRIES to the SYSTEM_TABLES set in IcebergTableName so the suffix is recognized and parsed. Wire the METADATA_LOG_ENTRIES case in IcebergAbstractMetadata.getIcebergSystemTable to construct a MetadataLogTable instance.	`presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergTableType.java` `presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergTableName.java` `presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java`
Add tests validating the $metadata_log_entries table schema, behavior, and time zone handling.	Add IcebergDistributedTestBase tests to verify row counts and latest_snapshot_id behavior for $metadata_log_entries after table creation and inserts. Add parameterized tests over multiple time zones to ensure timestamp encoding and expected rows from $metadata_log_entries align with Iceberg TableMetadata timestamps and metadata file locations. Extend TestIcebergSystemTables to validate the column definitions of $metadata_log_entries and ensure queries succeed on partitioned test tables.	`presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java` `presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestIcebergSystemTables.java`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes - here's some feedback:

In MetadataLogTable.cursor's iterator, next() returns emptyList() when there are no more entries instead of throwing NoSuchElementException; it would be clearer and safer to align with the Iterator contract and make that branch unreachable (or throw) when hasNext() is false.
In MetadataLogTable.processMetadataLogEntries, the broad catch (IllegalArgumentException ignored) silently swallows all such errors; consider tightening the condition or at least documenting the exact scenarios you expect here (and possibly logging unexpected cases) so debugging issues around snapshotIdAsOfTime is easier.
In testMetadataLogTableWithTimeZoneId, resultBuilder uses getSession() instead of sessionForTimeZone, which may hide timezone-specific behavior; consider using the same session as the query execution to keep expectations consistent with the selected timezone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `MetadataLogTable.cursor`'s iterator, `next()` returns `emptyList()` when there are no more entries instead of throwing `NoSuchElementException`; it would be clearer and safer to align with the Iterator contract and make that branch unreachable (or throw) when `hasNext()` is false.
- In `MetadataLogTable.processMetadataLogEntries`, the broad `catch (IllegalArgumentException ignored)` silently swallows all such errors; consider tightening the condition or at least documenting the exact scenarios you expect here (and possibly logging unexpected cases) so debugging issues around `snapshotIdAsOfTime` is easier.
- In `testMetadataLogTableWithTimeZoneId`, `resultBuilder` uses `getSession()` instead of `sessionForTimeZone`, which may hide timezone-specific behavior; consider using the same session as the query execution to keep expectations consistent with the selected timezone.

## Individual Comments

### Comment 1
<location> `presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java:108` </location>
<code_context>
+                    TableMetadata currentMetadata = ((BaseTable) icebergTable).operations().current();
+                    return buildLatestMetadataRow(session, currentMetadata);
+                }
+                return emptyList();
+            }
+        };
</code_context>

<issue_to_address>
**issue (bug_risk):** Avoid returning an empty row when the iterator is exhausted; use NoSuchElementException instead.

`Iterator.next()` should throw `NoSuchElementException` when there are no more elements. The current `return emptyList();` would produce a row with an incorrect column count and violate `InMemoryRecordSet` expectations, leading to confusing failures. Replace the final return with `throw new NoSuchElementException();` to honor the iterator contract and fail explicitly.
</issue_to_address>

### Comment 2
<location> `presto-docs/src/main/sphinx/connector/iceberg.rst:551` </location>
<code_context>
                                                       assign a split to. Splits which read data from the same file within
                                                       the same chunk will hash to the same node. A smaller chunk size will
                                                       result in a higher probability splits being distributed evenly across
-                                                      the cluster, but reduce locality. 
+                                                      the cluster, but reduce locality.
</code_context>

<issue_to_address>
**suggestion (typo):** Consider adjusting the phrase to "higher probability of splits" for correct grammar.

This sentence is missing the preposition "of" after "probability," which is why it currently reads awkwardly.

```suggestion
                                                      result in a higher probability of splits being distributed evenly across
```
</issue_to_address>

### Comment 3
<location> `presto-docs/src/main/sphinx/connector/iceberg.rst:945` </location>
<code_context>
 All above metadata tables, except `$changelog`, are supported in Presto C++.
+``$metadata_log_entries`` Table
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+* ``$metadata_log_entries`` : Provide metadata log entries for the table
+
+.. code-block:: sql
</code_context>

<issue_to_address>
**suggestion (typo):** Use "Provides" instead of "Provide" for subject–verb agreement.

Because `$metadata_log_entries` is singular, the description should be: "Provides metadata log entries for the table."

```suggestion
* ``$metadata_log_entries`` : Provides metadata log entries for the table
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

sourcery-ai · 2025-12-04T12:37:15Z

presto-docs/src/main/sphinx/connector/iceberg.rst

                                                      is hashed to a particular node when determining the which worker to
                                                      assign a split to. Splits which read data from the same file within
                                                      the same chunk will hash to the same node. A smaller chunk size will
                                                      result in a higher probability splits being distributed evenly across


suggestion (typo): Consider adjusting the phrase to "higher probability of splits" for correct grammar.

This sentence is missing the preposition "of" after "probability," which is why it currently reads awkwardly.

Suggested change

result in a higher probability splits being distributed evenly across

result in a higher probability of splits being distributed evenly across

sourcery-ai · 2025-12-04T12:37:15Z

presto-docs/src/main/sphinx/connector/iceberg.rst

 All above metadata tables, except `$changelog`, are supported in Presto C++.
+``$metadata_log_entries`` Table
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+* ``$metadata_log_entries`` : Provide metadata log entries for the table


suggestion (typo): Use "Provides" instead of "Provide" for subject–verb agreement.

Because $metadata_log_entries is singular, the description should be: "Provides metadata log entries for the table."

Suggested change

* ``$metadata_log_entries`` : Provide metadata log entries for the table

* ``$metadata_log_entries`` : Provides metadata log entries for the table

steveburnett

Thanks for the documentation! One small nit, and a question.

presto-docs/src/main/sphinx/connector/iceberg.rst

steveburnett

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

hantangwangd

@agrawalreetika thanks for this feature. The change looks good to me, just one little thing left.

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java

hantangwangd

LGTM! Please handle the maven checks failure.

ZacBlanco

LGTM

## Description Fix protocol generation after changes introduced by #24302 by running the `make presto_protocol` command. ## Impact No impact ## Test Plan CI ## Contributor checklist - [x] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [x] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [x] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [x] Adequate tests were added if applicable. - [x] CI passed. - [x] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```

agrawalreetika requested review from a team, ZacBlanco, elharo, hantangwangd and steveburnett as code owners December 29, 2024 05:45

agrawalreetika requested a review from presto-oss December 29, 2024 05:45

prestodb-ci added the from:IBM PR from IBM label Dec 29, 2024

prestodb-ci requested review from a team, infvg and pratyakshsharma and removed request for a team December 29, 2024 05:45

hantangwangd reviewed Jan 1, 2025

View reviewed changes

ZacBlanco requested changes Jan 3, 2025

View reviewed changes

steveburnett previously approved these changes Jan 3, 2025

View reviewed changes

agrawalreetika dismissed steveburnett’s stale review via b4d52b7 January 4, 2025 05:23

agrawalreetika force-pushed the metadata_log_entries branch 4 times, most recently from 8f6f007 to e66d10e Compare January 5, 2025 05:38

agrawalreetika marked this pull request as draft January 6, 2025 02:33

agrawalreetika self-assigned this Jan 6, 2025

agrawalreetika force-pushed the metadata_log_entries branch from e66d10e to fa36f6b Compare December 4, 2025 12:16

agrawalreetika changed the title ~~[Iceberg] Add Iceberg metadata table $metadata_log_entries~~ feat(plugin-iceberg): Add Iceberg metadata table $metadata_log_entries Dec 4, 2025

agrawalreetika marked this pull request as ready for review December 4, 2025 12:35

prestodb-ci requested a review from a team December 4, 2025 12:36

sourcery-ai bot reviewed Dec 4, 2025

View reviewed changes

agrawalreetika force-pushed the metadata_log_entries branch 2 times, most recently from 9b264dc to 66bdfba Compare December 4, 2025 14:39

steveburnett requested changes Dec 4, 2025

View reviewed changes

presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/connector/iceberg.rst Show resolved Hide resolved

agrawalreetika force-pushed the metadata_log_entries branch from 66bdfba to 47b356e Compare December 4, 2025 15:41

steveburnett previously approved these changes Dec 4, 2025

View reviewed changes

agrawalreetika requested review from ZacBlanco and hantangwangd December 4, 2025 19:37

hantangwangd reviewed Dec 12, 2025

View reviewed changes

presto-iceberg/src/main/java/com/facebook/presto/iceberg/MetadataLogTable.java Outdated Show resolved Hide resolved

agrawalreetika dismissed steveburnett’s stale review via 324c06c December 12, 2025 07:23

agrawalreetika force-pushed the metadata_log_entries branch 2 times, most recently from 324c06c to 2ca5ef8 Compare December 12, 2025 07:38

hantangwangd previously approved these changes Dec 12, 2025

View reviewed changes

agrawalreetika dismissed hantangwangd’s stale review via d64783c December 12, 2025 10:18

agrawalreetika force-pushed the metadata_log_entries branch from 2ca5ef8 to d64783c Compare December 12, 2025 10:18

hantangwangd approved these changes Dec 12, 2025

View reviewed changes

tdcmeehan approved these changes Dec 12, 2025

View reviewed changes

Add Iceberg metadata table $metadata_log_entries

bb06774

agrawalreetika force-pushed the metadata_log_entries branch from d64783c to bb06774 Compare December 14, 2025 18:41

ZacBlanco approved these changes Dec 16, 2025

View reviewed changes

agrawalreetika merged commit 9b595a9 into prestodb:master Dec 16, 2025
111 of 113 checks passed

agrawalreetika deleted the metadata_log_entries branch December 16, 2025 19:06

pdabre12 mentioned this pull request Jan 13, 2026

fix(native): Fix protocol generation #26956

Merged

7 tasks

This was referenced Mar 31, 2026

docs: Add release notes for 0.297 unix280/presto#51

Closed

docs: Add release notes for 0.297 unix280/presto#52

Open

prestodb-ci mentioned this pull request Apr 1, 2026

docs: Add release notes for 0.297 #27484

Open

15 tasks

	snapshotId = SnapshotUtil.snapshotIdAsOfTime(icebergTable, entry.timestampMillis());
	snapshotId = snapshotIdAsOfTime(icebergTable, entry.timestampMillis());

	result in a higher probability splits being distributed evenly across
	result in a higher probability of splits being distributed evenly across

	* ``$metadata_log_entries`` : Provide metadata log entries for the table
	* ``$metadata_log_entries`` : Provides metadata log entries for the table

Conversation

agrawalreetika commented Dec 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Uh oh!

hantangwangd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hantangwangd Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZacBlanco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot commented Dec 4, 2025

Reviewer's Guide

Sequence diagram for querying the Iceberg $metadata_log_entries system table

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sourcery-ai bot Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

hantangwangd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hantangwangd left a comment

Choose a reason for hiding this comment

Uh oh!

ZacBlanco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agrawalreetika commented Dec 29, 2024 •

edited

Loading

hantangwangd Jan 4, 2025 •

edited

Loading