Skip to content

chore(ci): Advance Velox #26385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditi-pandit merged 1 commit into from
Oct 25, 2025
Merged

chore(ci): Advance Velox #26385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions presto-native-execution/presto_cpp/main/SessionProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,12 +562,12 @@ SessionProperties::SessionProperties() {
std::to_string(c.maxOutputBatchRows()));

addSessionProperty(
kRowSizeTrackingEnabled,
"A fallback for average row size estimate when not supported for certain readers. Turned on by default.",
BOOLEAN(),
kRowSizeTrackingMode,
"Enable (reader) row size tracker as a fallback to file level row size estimates.",
INTEGER(),
true,
QueryConfig::kRowSizeTrackingEnabled,
std::to_string(c.rowSizeTrackingEnabled()));
QueryConfig::kRowSizeTrackingMode,
std::to_string(static_cast<int32_t>(c.rowSizeTrackingMode())));
Copy link
Copy Markdown
Contributor

@aditi-pandit aditi-pandit Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang : This is just going to show 1, 2, 3 and not the string versions of the enums. We should ask Velox team to expose the string names of the enums (they have a macro for it) which we can use here.

facebookincubator/velox#15111 (review)

Copy link
Copy Markdown
Contributor Author

@tanjialiang tanjialiang Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can do a followup on this


addSessionProperty(
kUseVeloxGeospatialJoin,
Expand Down
3 changes: 1 addition & 2 deletions presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,7 @@ class SessionProperties {

/// Enable (reader) row size tracker as a fallback to file level row size
/// estimates.
static constexpr const char* kRowSizeTrackingEnabled =
"row_size_tracking_enabled";
static constexpr const char* kRowSizeTrackingMode = "row_size_tracking_mode";

/// If this is true, then the protocol::SpatialJoinNode is converted to a
/// velox::core::SpatialJoinNode. Otherwise, it is converted to a
Expand Down
5 changes: 4 additions & 1 deletion presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <gtest/gtest.h>
#include "presto_cpp/main/TaskManager.h"
#include "presto_cpp/main/common/Configs.h"
#include "velox/core/QueryConfig.h"

namespace facebook::presto {

Expand Down Expand Up @@ -79,7 +80,9 @@ TEST_F(QueryContextManagerTest, nativeSessionProperties) {
EXPECT_TRUE(queryCtx->queryConfig().debugDisableExpressionsWithMemoization());
EXPECT_TRUE(queryCtx->queryConfig().debugDisableExpressionsWithLazyInputs());
EXPECT_TRUE(queryCtx->queryConfig().selectiveNimbleReaderEnabled());
EXPECT_TRUE(queryCtx->queryConfig().rowSizeTrackingEnabled());
EXPECT_EQ(
queryCtx->queryConfig().rowSizeTrackingMode(),
facebook::velox::core::QueryConfig::RowSizeTrackingMode::ENABLED_FOR_ALL);
EXPECT_EQ(queryCtx->queryConfig().preferredOutputBatchBytes(), 10UL << 20);
EXPECT_EQ(queryCtx->queryConfig().preferredOutputBatchRows(), 1024);
EXPECT_EQ(queryCtx->queryConfig().spillWriteBufferSize(), 1024);
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Open in desktop
Submodule velox updated 233 files
Loading