feat(dwio): Enable row size tracking for metalake separately#15111
Closed
HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat(dwio): Enable row size tracking for metalake separately#15111HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
HuamengJiang wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@HuamengJiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84228406. |
HuamengJiang
force-pushed
the
export-D84228406
branch
2 times, most recently
from
5d71fd7 to
3bd5dc1
Compare
HuamengJiang
force-pushed
the
export-D84228406
branch
from
3bd5dc1 to
0374311
Compare
HuamengJiang
force-pushed
the
export-D84228406
branch
from
0374311 to
35b6a16
Compare
HuamengJiang
force-pushed
the
export-D84228406
branch
from
35b6a16 to
1b1497f
Compare
Yuhta
approved these changes
Oct 16, 2025
HuamengJiang
force-pushed
the
export-D84228406
branch
from
1b1497f to
213538d
Compare
…kincubator#15111) Summary: Due to extra integration uncertainty in the metalake path and some previous QB signals, we decide to separately control row size tracking for metalake with the session property. Instead of adding an additional session property, we decide to extend the current one. However, due to changing the session property type breaking backward compatibility, we still ended up introducing a new query config. We will delete the deprecated bool session property as the 3rd diff in the stack. Reviewed By: Yuhta Differential Revision: D84228406
HuamengJiang
force-pushed
the
export-D84228406
branch
from
213538d to
e3ba7e2
Compare
|
This pull request has been merged in f9b67ea. |
Collaborator
aditi-pandit
left a comment
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks for this PR.
| } | ||
| #endif | ||
|
|
||
| RowSizeTrackingMode rowSizeTrackingMode() const { |
Collaborator
There was a problem hiding this comment.
@HuamengJiang : It would be great to expose std::string getters and setters as well for this value.
It is exposed as a session property by Prestissimo and it will be better for engines to not have to reimplement the string conversions for this enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Due to extra integration uncertainty in the metalake path and some previous QB signals, we decide to separately control row size tracking for metalake with the session property.
Instead of adding an additional session property, we decide to extend the current one. However, due to changing the session property type breaking backward compatibility, we still ended up introducing a new query config. We will delete the deprecated bool session property as the 3rd diff in the stack.
Differential Revision: D84228406